Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier config recalculation at the start of each era #1230

Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Apr 29, 2024

Pull Request Summary

Modifies dApp staking v3 so tier config is recalculated after each era.
This change is important for the upcoming Oracle integration into Shiden & Astar since the goal is to make system more adjustable & flexible.

Right now a big problem is that ASTR price has dropped significantly which is causing devs to earn less.
This PR is one of two steps required to address the issue.

TODO

  • re-run benchmarks

@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Apr 29, 2024
@Dinonard Dinonard self-assigned this Apr 29, 2024
@Dinonard Dinonard linked an issue Apr 29, 2024 that may be closed by this pull request
@Dinonard
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_dapp_staking_v3

Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/8893556626.
Please wait for a while.
Branch: feat/dapp-staking-dynamic-tier-config-recalculation
SHA: 7a863e2

Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/8893556626.

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
minor nitpick for typo in comment

pallets/dapp-staking-v3/src/test/tests.rs Outdated Show resolved Hide resolved
Co-authored-by: Ashutosh Varma <ashutoshvarma11@live.com>
PierreOssun
PierreOssun previously approved these changes May 1, 2024
@Dinonard
Copy link
Member Author

Dinonard commented May 1, 2024

/bench shiden-dev pallet_dapp_staking_v3

Copy link

github-actions bot commented May 1, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/8913867389.
Please wait for a while.
Branch: feat/dapp-staking-dynamic-tier-config-recalculation
SHA: 53a9b1a

Copy link

github-actions bot commented May 1, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/8913867389.

Copy link

github-actions bot commented May 2, 2024

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-v3/src 92% 0%
precompiles/xcm/src 73% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/static-price-provider/src 52% 0%
pallets/xvm/src 54% 0%
pallets/price-aggregator/src 72% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/substrate-ecdsa/src 74% 0%
chain-extensions/xvm/src 0% 0%
precompiles/xvm/src 75% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/xc-asset-config/src 64% 0%
primitives/src 61% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/unified-accounts/src 100% 0%
pallets/ethereum-checked/src 79% 0%
precompiles/assets-erc20/src 81% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/unified-accounts/src 86% 0%
pallets/oracle-benchmarks/src 0% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/xvm/src 0% 0%
primitives/src/xcm 64% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/inflation/src 83% 0%
Summary 78% (3599 / 4632) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit 1722e4c into master May 2, 2024
8 checks passed
@Dinonard Dinonard deleted the feat/dapp-staking-dynamic-tier-config-recalculation branch May 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dApp Staking v3 - More Dynamic Tier Calculation
3 participants