-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix export genesis state #1233
fix export genesis state #1233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Really weird we had this custom logic instead of using what's available 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This was introduced in v1.1.0 uplift by me. The new genesis cmd required client (executor) as new argument for pulling state_version
, and we had issue with zombienet testing.
- The correct logic was added in this commit only to be overwritten by upcoming commits.
- I think I tried to streamlined the cmd by pulling the current
state_version
instead of creating partials for each spec in order to isolate the issue to genesis mismatch, it was an oversight.
Thanks for fixing it!
@ashutoshvarma oh right, now I remember! |
Signed-off-by: Ermal Kaleci <ermalkaleci@gmail.com>
6597315
to
c739984
Compare
Minimum allowed line rate is |
Use of state_version 1 is incorrect since chain was started with state_version 0.
Instead of generation genesis header manually we use substrate cmd