-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove genesis state print #1235
Conversation
Dumb question - why is it incorrect? |
it's using state_version 1 |
@ermalkaleci How about hardcoding the |
Then it will be wrong for local and dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I checked the code now so it's clear.
Good catch! 💪 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it will be wrong for local and dev
@ermalkaleci
We don't print this for local (dev) since it's standalone chain. (nvm, still wrong for zombienet)
But as Dino said it's not useful anyways so let's remove it. Great find!
@Dinonard didn't have gpg setup before so I can't merge this. Can you do it? |
Uh, no, they have to be signed. I don't have admin rights for the repo. Can you force-push the signed commits? |
Signed-off-by: Ermal Kaleci <ermalkaleci@gmail.com>
798d87b
to
980c06b
Compare
force-push works |
Minimum allowed line rate is |
This genesis state generated is incorrect. If we don't need it then better remove it
closes #1234