Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect check for locked/frozen amount #1275

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Dinonard
Copy link
Member

Pull Request Summary

When lock is called, the total_balance needs to be compared against complete frozen balance in dApp staking.
RIght now, incorrect function was called which only returned amount which was actively locked (not undergoing the unlocking period).

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jun 21, 2024
@Dinonard Dinonard self-assigned this Jun 21, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/astar-xcm-benchmarks/src 88% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/collator-selection/src 92% 0%
pallets/oracle-benchmarks/src 0% 0%
precompiles/xcm/src 73% 0%
primitives/src/xcm 64% 0%
chain-extensions/types/assets/src 0% 0%
pallets/ethereum-checked/src 79% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
primitives/src 62% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapp-staking-migration/src 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/unified-accounts/src 86% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/xc-asset-config/src 64% 0%
precompiles/assets-erc20/src 81% 0%
pallets/inflation/src 83% 0%
pallets/price-aggregator/src 72% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/xvm/src 54% 0%
pallets/dapp-staking-v3/src 90% 0%
precompiles/sr25519/src 64% 0%
precompiles/xvm/src 75% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/static-price-provider/src 52% 0%
chain-extensions/types/xvm/src 0% 0%
Summary 77% (3647 / 4717) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit f63d30e into master Jun 21, 2024
11 of 12 checks passed
@Dinonard Dinonard deleted the fix/incorrect-freeze-lock-check branch June 21, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants