Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep v5.43.0 #1323

Merged
merged 2 commits into from
Aug 9, 2024
Merged

prep v5.43.0 #1323

merged 2 commits into from
Aug 9, 2024

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Aug 9, 2024

Pull Request Summary

Prepare new client & runtime release

@ermalkaleci ermalkaleci added the client This PR/Issue is related to the topic “client”. label Aug 9, 2024
@Dinonard
Copy link
Member

Dinonard commented Aug 9, 2024

LGTM - just a question about EVM tracing.

Since spec_version wasn't updated, we'll have a new evm tracing archive with new runtimes, but with old spec_version. If some operator has an automation script (or something), they might overwrite the old (correct) binaries.

Just to keep in mind:

  • either we bump spec versions and make it into a normal release
    • (Why not? We can test the uplift on Shinjuku/Shibuya first, without risking a real production network)
  • manually cleanup evm tracing archive

@ermalkaleci
Copy link
Contributor Author

  • y cleanup evm tracing archiv

They should not do it automatically. Not every release goes on-chain

@ermalkaleci
Copy link
Contributor Author

We can bump runtime as well and not upgrade until we do further testing. I want client out so we solve missed blocks

@Dinonard
Copy link
Member

Dinonard commented Aug 9, 2024

They should not do it automatically. Not every release goes on-chain

Not sure what to say about this tbh - I'd prefer if it was automated, at least to some degree.
But the main issue here I see is the two releases that might have same runtime blobs (evm tracing).

@ermalkaleci
Copy link
Contributor Author

evm-tracing node needs to be updated only when there's new runtime upgrade

@ermalkaleci
Copy link
Contributor Author

@Dinonard I'm fine with bumping spec_version

@ermalkaleci
Copy link
Contributor Author

@Dinonard bumped

@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test shibuya

@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test shiden

@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test astar

Copy link

github-actions bot commented Aug 9, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321112432.
Please wait for a while.
Runtime: shibuya
Branch: feat/prep-5.43.0
SHA: 9d145c6

Copy link

github-actions bot commented Aug 9, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321114844.
Please wait for a while.
Runtime: astar
Branch: feat/prep-5.43.0
SHA: 9d145c6

Copy link

github-actions bot commented Aug 9, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321113307.
Please wait for a while.
Runtime: shiden
Branch: feat/prep-5.43.0
SHA: 9d145c6

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Aug 9, 2024

Runtime upgrade test finished:

yarn run v1.22.22
$ RUNTIME=shiden yarn test tests/runtime-upgrade.test.ts
$ LOG_LEVEL=error vitest --silent --no-color tests/runtime-upgrade.test.ts

RUN v1.6.0 /home/runner/work/Astar/Astar/tests/e2e

✓ tests/runtime-upgrade.test.ts (1 test) 40982ms

Test Files 1 passed (1)
Tests 1 passed (1)
Start at 14:54:36
Duration 44.92s (transform 34ms, setup 0ms, collect 3.66s, tests 40.98s, environment 0ms, prepare 72ms)

Done in 45.48s.

Copy link

github-actions bot commented Aug 9, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/inflation/src 93% 0%
pallets/collator-selection/src 92% 0%
pallets/price-aggregator/src 82% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/static-price-provider/src 85% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/assets-erc20/src 78% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/ethereum-checked/src 74% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/dapp-staking-v3/src 84% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/collective-proxy/src 86% 0%
primitives/src 59% 0%
precompiles/xcm/src 71% 0%
precompiles/dapp-staking-v3/src 90% 0%
primitives/src/xcm 65% 0%
precompiles/sr25519/src 64% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
chain-extensions/types/assets/src 0% 0%
pallets/unified-accounts/src 86% 0%
Summary 77% (3565 / 4627) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link

github-actions bot commented Aug 9, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321112432.
Please wait for a while.
Runtime: shibuya
Branch: feat/prep-5.43.0
SHA: 9d145c6

@ermalkaleci ermalkaleci merged commit a642a44 into master Aug 9, 2024
9 checks passed
@ermalkaleci ermalkaleci deleted the feat/prep-5.43.0 branch August 9, 2024 14:58
Copy link

github-actions bot commented Aug 9, 2024

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321114844.
Please wait for a while.
Runtime: astar
Branch: feat/prep-5.43.0
SHA: 9d145c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client This PR/Issue is related to the topic “client”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants