-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async backing migrations #1343
async backing migrations #1343
Conversation
/bench shibuya-dev vesting_mbm |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10603441103. |
Benchmarks have been finished. |
…c-backing-migrations
…c-backing-migrations
/bench shibuya-dev pallet-dapp-staking |
/bench shibuya-dev pallet-dapp-staking |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10684800692. |
Benchmarks have been finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pallet_inflation
needs to be updated to account for theInflationConfiguration
DB entry with_per_block
values. These should be halved.pallet_price_aggregator
hasValueAggregator
value withlimit_block
value which should be updateddapp_staking
needs more updates:ProtocolState
'snext_era_start
needs to be updatedInflationCycleConfig
struct in Shibuya runtime is related to thenext_era_start
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor questions
@ermalkaleci I am not seeing this, are you going to do it later? |
It isn't that important. We decided to skip it |
/bench shibuya-dev pallet-dapp-staking |
Pull Request Summary
Multi-block migrations for pallet-vesting
Enable async backing on shibuya and adjust parameters
OnTimestampSet to Aura to validate timestamp based on slot
Check list