Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp staking - crate visibility #1345

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Chore task, remnant from the audit, to cleanup pub visibility.

@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Aug 29, 2024
@Dinonard Dinonard marked this pull request as ready for review August 29, 2024 14:10
@Dinonard Dinonard linked an issue Aug 29, 2024 that may be closed by this pull request
ermalkaleci
ermalkaleci previously approved these changes Aug 29, 2024
ipapandinas
ipapandinas previously approved these changes Aug 29, 2024
Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests passed

@Dinonard Dinonard dismissed stale reviews from ipapandinas and ermalkaleci via 879048a August 30, 2024 06:42
@Dinonard
Copy link
Member Author

Integration tests fixed.

I had to reluctantly introduce one setter for the next era start block to provide significant speed boost for the tests.
I can still remove it of course, LMKWYT.

Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/unified-accounts/src 86% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/dapp-staking/src 90% 0%
pallets/collective-proxy/src 86% 0%
pallets/dapp-staking/src/test 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/inflation/src 93% 0%
pallets/price-aggregator/src 82% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/xcm/src 71% 0%
pallets/ethereum-checked/src 74% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/assets-erc20/src 78% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/dapp-staking/src/test 0% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/sr25519/src 64% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
primitives/src 57% 0%
pallets/static-price-provider/src 85% 0%
primitives/src/xcm 65% 0%
pallets/dapp-staking/src 83% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/dispatch-lockdrop/src 86% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/collator-selection/src 92% 0%
precompiles/unified-accounts/src 100% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
Summary 79% (3647 / 4622) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit 4f74868 into master Aug 30, 2024
8 checks passed
@Dinonard Dinonard deleted the chore/ds-pub-visibility-cleanup branch August 30, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dApp staking v3 - pub(crate) visibility
3 participants