uplift to stable2407

[vedhavyas]

Pull Request Summary
PR uplifts to stable 2407.
Commit one uplifts the project
Commit two bumps the versions

Check list

• added or updated unit tests
• updated Astar official documentation
• added OnRuntimeUpgrade hook for precompile revert code registration
• added benchmarks & weights for any modified runtime logics.

[Dinonard]

For the treasury changes, we also need to update the docs and inform the Subsquare team to update the UI logic.

[vedhavyas]

New treasury changes requires the origin to return the Max amount to spend at a time and I have set the Max to Max Balance.

As for the Payout timeout, I have set 3 days for shibuya and 30 minutes for Local. After this period, the spends are expired

For the treasury changes, we also need to update the docs and inform the Subsquare team to update the UI logic.

@Dinonard How do I start doing that ?

[ipapandinas]

LGTM

[ipapandinas]

It's missing xcmp-queue v5 migrations as Ermal noticed

[vedhavyas]

It's missing xcmp-queue v5 migrations as Ermal noticed

yes I'min the process of adding those :)

[vedhavyas]

@ipapandinas Due to this recent patch to stable2407 paritytech/polkadot-sdk#5913
I had to adjust xcm dry tests. FYI since you seems to have written them

[ipapandinas]

nice catch on the XCM dry-run patch! those tests are purely integration tests to ensure that the runtime API is correctly implemented

now that you've reversed the treasury updates, the changes are lighter, so I approve the uplift ✅

Good job! 👏

[vedhavyas]

Pallet treasury is forked from https://github.com/AstarNetwork/polkadot-sdk/tree/stable2407 after applying necessary reverts so that we fork the upto date version of pallet

[Dinonard]

Looks good now!

Just one question about the placement - would it be more appropriate for the vendor folder given we already have there reused crates from other projects?

[github-actions]

Package	Line Rate	Branch Rate	Health
pallets/vesting-mbm/src	89%	0%	✔
precompiles/dapp-staking/src/test	0%	0%	❌
chain-extensions/types/unified-accounts/src	0%	0%	❌
pallets/inflation/src	89%	0%	✔
pallets/ethereum-checked/src	74%	0%	➖
precompiles/assets-erc20/src	78%	0%	➖
pallets/xc-asset-config/src	50%	0%	❌
chain-extensions/unified-accounts/src	0%	0%	❌
chain-extensions/types/assets/src	0%	0%	❌
pallets/dapp-staking/rpc/runtime-api/src	0%	0%	❌
pallets/collective-proxy/src	86%	0%	✔
precompiles/sr25519/src	64%	0%	➖
pallets/dapp-staking/src	83%	0%	✔
pallets/static-price-provider/src	85%	0%	✔
precompiles/dispatch-lockdrop/src	86%	0%	✔
pallets/dapp-staking/src/benchmarking	98%	0%	✔
pallets/unified-accounts/src	86%	0%	✔
primitives/src	57%	0%	➖
pallets/price-aggregator/src	82%	0%	✔
precompiles/substrate-ecdsa/src	74%	0%	➖
pallets/dapp-staking/src/test	0%	0%	❌
pallets/dynamic-evm-base-fee/src	89%	0%	✔
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
chain-extensions/pallet-assets/src	56%	0%	➖
precompiles/xcm/src	71%	0%	➖
precompiles/dapp-staking/src	90%	0%	✔
precompiles/unified-accounts/src	100%	0%	✔
pallets/collator-selection/src	92%	0%	✔
pallets/astar-xcm-benchmarks/src	86%	0%	✔
primitives/src/xcm	65%	0%	➖
Summary	79% (3730 / 4738)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

[Dinonard]

LGTM!

[Dinonard]

/runtime-upgrade-test shibuya

[github-actions]

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11478975444.
Please wait for a while.
Runtime: shibuya
Branch: uplift-stable2407
SHA: f2cfc25

[vedhavyas]

@Dinonard are we expected to run these tests now? Looks like they failed due to the specVersion check which we decided to rollback in this PR :)

[Dinonard]

@Dinonard no, it's fine, I triggered the wrong one (wanted to run the migration check).

But the check can also be configured to ignore the spec version check, if needed.

[vedhavyas]

is this good to be merged or should we merge after the testing on shinjoku ?

[Dinonard]

You can merge it, but we need to test on Shinjuku and Shibuya before the actual release.

[vedhavyas]

yeah, I have asked for access. Will test there and merge after
Though I believe for try-runtime, we need to update the specVersions

What was process for previous uplifts. What was the versions updated ?

[Dinonard]

We don't update versions when doing the uplifts, it's done in a separate PR before making the release.

So you can merge this PR, and follow-it up with tests on the Shinjuku & Shibuya.
We can proceed with the release next week.