Astar Governance Integration

[Dinonard]

Governance V1 on Astar

Integration of governance related functionality into Astar runtime.
Mirrors the Shibuya solution

TODO

• enable dispatch precompile calls

Params Overview

Collectives

• collective motion duration is 5 days, giving enough time for the collective members to vote aye or nay

Democracy

• launch period will last for 7 days, upgrading a new proposal into a referendum once per week
• voting period will last for 7 days, allowing ample time for token holders to vote
• enactment period will take 2 days in case referendum has passed
• base locking period will be 9 days, to match with the dApp staking (conviction voting applies)
  • this shouldn't be a problem since active members will most likely be both staking & voting
• minimum deposit for creating a democracy proposal will be 1000 ASTR

Treasury

• 5% of the treasury request will be reserved as collateral, but reserved value will always be at least 100 ASTR and not more than 1000 ASTR
• spend period for each treasury will be 7 days

Community Council

• 2/3 agreement to register a new dApp into dApp staking
• 4/5 agreement to unregister a dApp from dApp staking
• 2/3 agreement to execute staking action (lock/unlock/stake/unstake)
• 2/3 agreement to approve or reject a spending proposal

[ipapandinas]

LGTM - I hadn't reviewed the Shibuya implementation before, but you did a great job with this governance integration - kudos! 👏

[github-actions]

Package	Line Rate	Branch Rate	Health
pallets/xc-asset-config/src	50%	0%	❌
chain-extensions/pallet-assets/src	56%	0%	➖
chain-extensions/unified-accounts/src	0%	0%	❌
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
precompiles/dapp-staking/src/test	0%	0%	❌
pallets/unified-accounts/src	86%	0%	✔
pallets/dapp-staking/rpc/runtime-api/src	0%	0%	❌
pallets/dapp-staking/src	83%	0%	✔
pallets/inflation/src	89%	0%	✔
pallets/collator-selection/src	92%	0%	✔
pallets/vesting-mbm/src	89%	0%	✔
pallets/dapp-staking/src/benchmarking	98%	0%	✔
pallets/astar-xcm-benchmarks/src	86%	0%	✔
precompiles/substrate-ecdsa/src	74%	0%	➖
pallets/price-aggregator/src	82%	0%	✔
precompiles/xcm/src	71%	0%	➖
precompiles/unified-accounts/src	100%	0%	✔
pallets/dynamic-evm-base-fee/src	89%	0%	✔
chain-extensions/types/assets/src	0%	0%	❌
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
pallets/collective-proxy/src	86%	0%	✔
precompiles/dispatch-lockdrop/src	86%	0%	✔
primitives/src	57%	0%	➖
precompiles/assets-erc20/src	78%	0%	➖
pallets/ethereum-checked/src	74%	0%	➖
precompiles/dapp-staking/src	90%	0%	✔
chain-extensions/types/unified-accounts/src	0%	0%	❌
precompiles/sr25519/src	64%	0%	➖
pallets/static-price-provider/src	85%	0%	✔
pallets/dapp-staking/src/test	0%	0%	❌
primitives/src/xcm	65%	0%	➖
Summary	79% (3730 / 4738)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

[ermalkaleci]

LGTM

[Dinonard]

@ipapandinas can you please repeat the approval?

[ipapandinas]

LGTM