Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended kickout collator period #748

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Extended kickout collator period #748

merged 3 commits into from
Nov 13, 2022

Conversation

akru
Copy link
Contributor

@akru akru commented Sep 19, 2022 •
edited
Loading

Pull Request Summary

This PR increase collator kickout timeout.

Currently slashing is triggered on collators inactive for a period of 1 session (= 1 hour).

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@akru akru requested review from Dinonard and bLd75 September 19, 2022 03:18
bLd75
bLd75 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@bLd75 bLd75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dinonard
Dinonard reviewed Sep 19, 2022
View reviewed changes
runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
@akru akru force-pushed the feature/extended-collators-list branch from d303304 to e66eab7 Compare November 9, 2022 09:57
@akru akru merged commit 62e9445 into master Nov 13, 2022
@akru akru deleted the feature/extended-collators-list branch November 13, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bLd75 bLd75 bLd75 approved these changes

@Dinonard Dinonard Dinonard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akru @Dinonard @bLd75