Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench whitelist storage keys #785

Merged
merged 8 commits into from
Nov 17, 2022
Merged

Bench whitelist storage keys #785

merged 8 commits into from
Nov 17, 2022

Conversation

shunsukew
Copy link
Member

@shunsukew shunsukew commented Nov 15, 2022 •
edited
Loading

Pull Request Summary
This PR aims to improve pallet benchmarking.

  1. Make use of whitelist storage keys introduced by DappsStaking bench improvements astar-frame#112 on astar-frame side.
  2. Use macros to avoid code duplication (define_benchmarks!, list_benchmarks!, add_benchmarks!). See Improve usability of add+list_benchmark! paritytech/substrate#10592

Follow ups

  • Bench dapps staking pallet and update weights in astar-frame
  • Use new astar-frame package in Astar repo

Check list

  • updated semver

@shunsukew shunsukew changed the title whitelist storage keys [WIP] Whitelist storage keys Nov 15, 2022
@shunsukew shunsukew changed the title [WIP] Whitelist storage keys [WIP] Bench whitelist storage keys Nov 15, 2022
@shunsukew shunsukew changed the title [WIP] Bench whitelist storage keys Bench whitelist storage keys Nov 15, 2022
@shunsukew shunsukew marked this pull request as ready for review November 15, 2022 07:20
@shunsukew shunsukew requested review from Maar-io, akru, Dinonard and 0x7CFE and removed request for akru, Dinonard, 0x7CFE and Maar-io November 15, 2022 07:23
Dinonard
Dinonard approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks much cleaner than before 👍

@shunsukew shunsukew merged commit 1dde8b0 into master Nov 17, 2022
@shunsukew shunsukew deleted the bench-improvements branch November 17, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

@Maar-io Maar-io Awaiting requested review from Maar-io

@akru akru Awaiting requested review from akru

@0x7CFE 0x7CFE Awaiting requested review from 0x7CFE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunsukew @Dinonard