Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header to all .rs files #830

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Add header to all .rs files #830

merged 2 commits into from
Jan 18, 2023

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Added license header to all .rs files.

@Dinonard Dinonard force-pushed the feat/license-update branch from ca824e0 to 096446a Compare January 16, 2023 15:47
@Dinonard Dinonard marked this pull request as ready for review January 16, 2023 16:05
@Dinonard Dinonard requested review from akru and hoonsubin January 16, 2023 16:05
hoonsubin
hoonsubin reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@hoonsubin hoonsubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the HEADER-GNUv3 somehow checked during the format checking?

@Dinonard
Copy link
Member Author

Is the HEADER-GNUv3 somehow checked during the format checking?

No, but I found this: https://github.com/viperproject/check-license-header
Perhaps we could add it to our CI.

@akru
Copy link
Contributor

akru commented Jan 17, 2023

@hoonsubin @Dinonard May be better to use Astar Network instead of Stake Tech name?

@Dinonard
Copy link
Member Author

@hoonsubin @Dinonard May be better to use Astar Network instead of Stake Tech name?

I don't see a problem with that, but am no expert either 🙂

I based this on how substrate/polkadot/cumulus do it.
They have // Copyright (C) 2019-2022 Parity Technologies (UK) Ltd. in the header.

@hoonsubin
Copy link
Contributor

@hoonsubin @Dinonard May be better to use Astar Network instead of Stake Tech name?

I don't see a problem with that, but am no expert either 🙂

I based this on how substrate/polkadot/cumulus do it.

They have // Copyright (C) 2019-2022 Parity Technologies (UK) Ltd. in the header.

I guess Astar Foundation will look better.

@Dinonard Dinonard merged commit 4017ade into master Jan 18, 2023
@Dinonard Dinonard deleted the feat/license-update branch January 18, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoonsubin hoonsubin hoonsubin approved these changes

@akru akru akru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinonard @akru @hoonsubin