Feature/polkadot v0.9.36 #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….9.36 # Conflicts: # Cargo.lock # bin/collator/Cargo.toml # runtime/astar/Cargo.toml # runtime/local/Cargo.toml # runtime/shibuya/Cargo.toml # runtime/shiden/Cargo.toml
akru
reviewed
Feb 13, 2023
Dinonard
reviewed
Feb 14, 2023
| ( | ||
| pallet_multisig::migrations::v1::MigrateToV1<Runtime>, | ||
| pallet_assets::migration::v1::MigrateToV1<Runtime>, | ||
| pallet_balances::migration::MigrateToTrackInactive<Runtime, xcm_config::CheckingAccount>, |
There was a problem hiding this comment.
Do we even use xcm_config::CheckingAccount for Balances?
There was a problem hiding this comment.
I don't know, the line was taken from the cumulus PR.
There was a problem hiding this comment.
Let’s investigate a bit what’s expected to be here, just to make it clear.
There was a problem hiding this comment.
I don't know, the line was taken from the cumulus PR.
You should know or it should be documented somewhere that this needs to be understood better. You're owner of this uplift. 🤷♂️
Checking account is used for teleports so it's not relevant to us, there's nothing to migrate.
Dinonard
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Check list