Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --locked to cargo invocations #863

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Add --locked to cargo invocations #863

merged 2 commits into from
Feb 17, 2023

Conversation

0x7CFE
Copy link
Contributor

@0x7CFE 0x7CFE commented Feb 16, 2023 •
edited
Loading

Current CI does not check for outdated/uncommitted Cargo.lock.

By passing --locked we ensure that lock file should be up to date.

@0x7CFE 0x7CFE changed the title Add --frozen --locked to cargo invokations Add --locked to cargo invocations Feb 16, 2023
@0x7CFE 0x7CFE requested a review from shunsukew February 16, 2023 10:11
Dinonard
Dinonard approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@0x7CFE 0x7CFE merged commit ed4ed79 into master Feb 17, 2023
@0x7CFE 0x7CFE deleted the fix/locked-cargo-ci branch February 17, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

@shunsukew shunsukew Awaiting requested review from shunsukew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x7CFE @Dinonard