Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.yml #869

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Update release.yml #869

merged 1 commit into from
Feb 24, 2023

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Feb 23, 2023

I think the macOS fix is obvious, let's make sure it then does what you expect.

While running actionlint on the workflow directory, I found these errors.
bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)

release.yml:95:12: workflow command "set-output" was deprecated. use `echo "{name}={value}" >> $GITHUB_OUTPUT` instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions [deprecated-commands]
   |
95 |       run: echo "::set-output name=name::astar-ubuntu-latest-${TARGET%%-*}"
   |            ^~~~

release.yml:364:15: value "macos" in "exclude" does not exist in matrix "os" combinations. possible values are "ubuntu", "macOS" [matrix]
    |
364 |         - os: macos
    |               ^~~~~

release.yml:407:12: workflow command "set-output" was deprecated. use `echo "{name}={value}" >> $GITHUB_OUTPUT` instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions [deprecated-commands]
    |
407 |       run: |
    |            ^

Pull Request Summary

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

I think the macOS fix is obvious, let's make sure it then does what you expect.


```
release.yml:95:12: workflow command "set-output" was deprecated. use `echo "{name}={value}" >> $GITHUB_OUTPUT` instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions [deprecated-commands]
   |
95 |       run: echo "::set-output name=name::astar-ubuntu-latest-${TARGET%%-*}"
   |            ^~~~
release.yml:364:15: value "macos" in "exclude" does not exist in matrix "os" combinations. possible values are "ubuntu", "macOS" [matrix]
    |
364 |         - os: macos
    |               ^~~~~
release.yml:407:12: workflow command "set-output" was deprecated. use `echo "{name}={value}" >> $GITHUB_OUTPUT` instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions [deprecated-commands]
    |
407 |       run: |
    |            ^
```
@shunsukew shunsukew self-requested a review February 24, 2023 01:50
@Dinonard Dinonard merged commit 0877222 into master Feb 24, 2023
@Dinonard Dinonard deleted the gluneau-actionlint branch February 24, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants