Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove txpool from non-tracing build #993

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Aug 3, 2023

Pull Request Summary

Removes tx-pool when EVM tracing feature flag isn't used.
Otherwise we end up with two tx pool RPCs being created, which causes errors.

Check list

  • updated semver

@Dinonard Dinonard added the client This PR/Issue is related to the topic “client”. label Aug 3, 2023
@Dinonard Dinonard marked this pull request as ready for review August 3, 2023 09:24
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Code Coverage

Package Line Rate Branch Rate Health
precompiles/substrate-ecdsa/src 78% 0%
precompiles/xvm/src 67% 0%
pallets/xvm/src 0% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/ethereum-checked/src 48% 0%
pallets/collator-selection/src 69% 0%
chain-extensions/xvm/src 0% 0%
precompiles/sr25519/src 79% 0%
precompiles/xcm/src 84% 0%
pallets/custom-signatures/src 51% 0%
primitives/src/xcm 67% 0%
pallets/pallet-xcm/src 53% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/utils/src 70% 0%
pallets/dapps-staking/src 81% 0%
precompiles/utils/macro/src 0% 0%
primitives/src 69% 0%
precompiles/assets-erc20/src 76% 0%
pallets/contracts-migration/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/xc-asset-config/src 54% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/block-reward/src 85% 0%
Summary 55% (2271 / 4108) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit 79d4568 into master Aug 3, 2023
@Dinonard Dinonard deleted the fix/remove-tx-pool branch August 3, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client This PR/Issue is related to the topic “client”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants