Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rpc port #994

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix for rpc port #994

merged 1 commit into from
Aug 7, 2023

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Aug 3, 2023

Pull Request Summary

Latest version of zombienet takes WS port value to use for --rpc-port argument.

Although confusing, it is by design.

@Dinonard Dinonard marked this pull request as ready for review August 3, 2023 12:26
@Dinonard Dinonard added the tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Code Coverage

Package Line Rate Branch Rate Health
primitives/src/xcm 67% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/block-reward/src 85% 0%
pallets/dapps-staking/src 81% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/utils/src 70% 0%
pallets/collator-selection/src 69% 0%
precompiles/xvm/src 67% 0%
chain-extensions/xvm/src 0% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/xcm/src 84% 0%
pallets/custom-signatures/src 51% 0%
precompiles/assets-erc20/src 76% 0%
precompiles/utils/macro/src 0% 0%
pallets/contracts-migration/src 0% 0%
primitives/src 69% 0%
precompiles/substrate-ecdsa/src 78% 0%
pallets/xvm/src 0% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/pallet-xcm/src 53% 0%
pallets/xc-asset-config/src 54% 0%
precompiles/sr25519/src 79% 0%
Summary 55% (2271 / 4108) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit e26625a into master Aug 7, 2023
@Dinonard Dinonard deleted the fix/rpc-test-port branch August 7, 2023 06:49
PierreOssun pushed a commit that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants