Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show estimated staker + bonus rewards on vote info banner #1329

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jun 19, 2024

Pull Request Summary

Display sum of estimated APRs instead of the fixed value
image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Jun 19, 2024

Visit the preview URL for this PR (updated for commit f8c1278):

https://astar-apps--pr1329-fix-apr-on-bonus-pan-84nh1k14.web.app

(expires Wed, 26 Jun 2024 18:29:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's update the words as per @Kahonnohak suggested

@Kahonnohak
Copy link
Contributor

@bobo-k2
what I meant was here : Below Estimated Rewards... does this make sense?
Screenshot 2024-06-19 at 19 49 57

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jun 20, 2024

@bobo-k2 what I meant was here : Below Estimated Rewards... does this make sense?

aha got it now. I would change text sligtly to if you stake now.... It makes more sense to me, but you know my english :)

@bobo-k2 bobo-k2 merged commit 9236605 into release-hotfix Jun 20, 2024
5 of 6 checks passed
@bobo-k2 bobo-k2 deleted the fix/apr-on-bonus-panel branch June 20, 2024 06:53
gtg7784 pushed a commit that referenced this pull request Jun 21, 2024
* Add dApp staking categories description (#1316)

* Fix dApp swiper configuration (#1317)

* Fix dApp swiper configuration

* Rewards earned sort fix

* TVL ratio for previous period calculation fix

* Hide period stats

* Cast to bigint

* Hide period stats

* Fix for filtering dApps in other category (#1322)

* Category filter fix, take 2 (#1323)

* add airlyft to promotions (#1319)

* Show estimated staker + bonus rewards on vote info banner (#1329)

* Show estimated staker + bonus rewards on vote info banner

* Text update

* dApp Staking ranked tier update (#1324)

* Fetch rank rewards

* Add Hydration to XCM (#1315)

* Add rank reward calculation

* Map rankTier

* Type bug fix

* voting banner wording fix

---------

Co-authored-by: green-jay <75261756+green-jay@users.noreply.github.com>

* Tier display fix (#1331)

* hotfix: added maintenance mode condition to disable the bridge feature (#1330)

* Add Hydration to XCM (#1315)

* hotfix: disabled zKyoto bridge

---------

Co-authored-by: green-jay <75261756+green-jay@users.noreply.github.com>

---------

Co-authored-by: Bobo <bobo.kovacevic@gmail.com>
Co-authored-by: Rachit Magon <rachit.magon@gmail.com>
Co-authored-by: green-jay <75261756+green-jay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants