Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sklearn dependency #57

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Remove deprecated sklearn dependency #57

merged 2 commits into from
Dec 16, 2022

Conversation

dobraczka
Copy link
Contributor

@dobraczka dobraczka commented Dec 15, 2022

Summary

Fixes #56 by removing deprecated sklearn dependency.

  • Code passes all tests
  • Unit tests provided for these changes (does not apply)
  • Documentation and docstrings added for these changes (does not apply)

Changes

  • Remove deprecated sklearn dependency

jupyter-sphinx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this shows up in the diff 🤔

@kajocina
Copy link
Contributor

I updated something on the main branch for the CI to stop failing. Could you pull the changes to your fork and update the PR? Otherwise it will keep on failing CI :)

@codecov-commenter
Copy link

Codecov Report

Merging #57 (a7caa1f) into main (ce492dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          16       16           
  Lines         953      953           
=======================================
  Hits          947      947           
  Misses          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kajocina kajocina merged commit fef3b1a into AstraZeneca:main Dec 16, 2022
@mberr
Copy link

mberr commented Jan 9, 2023

Hi @kajocina

do you already know when you will release this fix? We are currently seeing some failing pipelines because of trying to install sklearn fetched as recursive dependency via rexmex.

@kajocina
Copy link
Contributor

Hey @mberr

just released the 0.1.3 with this fix!
Thanks for reminding us.

@mberr
Copy link

mberr commented Jan 10, 2023

Thanks for the quick response and release! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rexmex uses the deprecated sklearn dependency
4 participants