Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): enable gofumpt in gopls by default #1167

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(go): enable gofumpt in gopls by default #1167

merged 1 commit into from
Aug 19, 2024

Conversation

mehalter
Copy link
Member

📑 Description

Enables gofumpt over go fmt

ℹ Additional Information

Copy link

github-actions bot commented Aug 19, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter
Copy link
Member Author

@pgr0ss does this work for you? :)

@Uzaaft
Copy link
Member

Uzaaft commented Aug 19, 2024

Looks good. Should it be documented in the readme just in case?

@mehalter
Copy link
Member Author

Cool, I updated the readme. @Uzaaft can you go through the review checklist as the reviewer?

@pgr0ss
Copy link
Contributor

pgr0ss commented Aug 19, 2024

@pgr0ss does this work for you? :)

Yep, thanks!

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Uzaaft Uzaaft merged commit e61ce28 into main Aug 19, 2024
14 checks passed
@Uzaaft Uzaaft deleted the gopls_gofumpt branch August 19, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants