Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neotest): add watch keybindings #1185

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

cristobalgvera
Copy link
Contributor

@cristobalgvera cristobalgvera commented Sep 2, 2024

📑 Description

Add mappings to simplify the usage of watch-related commands when using neotest.

It also refactor the keybindings to follow current standards using an opts function instead of a table.

ℹ Additional Information

The API for the usage of neotest.watch.stop() is not well defined in terms of the type information for the usage.

This creates the necessity to use @diagnostic disable-next-line: missing-parameter.

For a closer look, see https://github.com/nvim-neotest/neotest/blob/master/doc/neotest.txt#L626

Copy link

github-actions bot commented Sep 2, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@cristobalgvera cristobalgvera force-pushed the dev-add-watch-to-neotest branch from e9a1779 to 8b94474 Compare September 2, 2024 12:32
@cristobalgvera cristobalgvera changed the title feat(neotest): add watch keymaps feat(neotest): add watch keybindings Sep 2, 2024
@cristobalgvera cristobalgvera force-pushed the dev-add-watch-to-neotest branch from 8b94474 to eb2b1cd Compare September 2, 2024 12:43
@cristobalgvera
Copy link
Contributor Author

I'm thinking to refactor this after the PR approval, in order to follow the standard process to map keybingings used in here

@cristobalgvera cristobalgvera force-pushed the dev-add-watch-to-neotest branch from eb2b1cd to 303dae8 Compare September 2, 2024 18:46
@Uzaaft
Copy link
Member

Uzaaft commented Sep 4, 2024

I'm thinking to refactor this after the PR approval, in order to follow the standard process to map keybingings used in here

Refactor first please. :)

@cristobalgvera cristobalgvera force-pushed the dev-add-watch-to-neotest branch from b2f8ed1 to 5acebee Compare September 8, 2024 18:35
@Uzaaft Uzaaft merged commit 09e9359 into AstroNvim:main Sep 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants