Skip to content

Merge pull request #441 from Asvarox/fix-security #1900

Merge pull request #441 from Asvarox/fix-security

Merge pull request #441 from Asvarox/fix-security #1900

Triggered via push January 29, 2025 21:15
Status Success
Total duration 10m 57s
Artifacts
Matrix: e2e-tests-run
deploy-branch
0s
deploy-branch
e2e-tests-add-summary
0s
e2e-tests-add-summary
Fit to window
Zoom out
Zoom in

Annotations

5 errors, 27 warnings, and 4 notices
[firefox] › rate-unfinished-song.spec.ts:54:5 › user can correctly select all of the shown reasons why the song was not completed: tests/rate-unfinished-song.spec.ts#L1
1) [firefox] › rate-unfinished-song.spec.ts:54:5 › user can correctly select all of the shown reasons why the song was not completed › User can return to Song List to choose another song Test timeout of 135000ms exceeded.
[firefox] › rate-unfinished-song.spec.ts:54:5 › user can correctly select all of the shown reasons why the song was not completed: tests/PageObjects/SongListPage.ts#L55
1) [firefox] › rate-unfinished-song.spec.ts:54:5 › user can correctly select all of the shown reasons why the song was not completed › User can return to Song List to choose another song Error: locator.click: Test timeout of 135000ms exceeded. Call log: - waiting for getByTestId('song-e2e-pass-test-spanish-1994') at PageObjects/SongListPage.ts:55 53 | public async openPreviewForSong(songID: string) { 54 | const locator = await this.getSongElement(songID); > 55 | await locator.click(); | ^ 56 | await expect(this.songPreviewElement).toHaveAttribute('data-song', songID); 57 | await locator.click({ force: true }); 58 | } at SongListPagePO.openPreviewForSong (/home/runner/work/allkaraoke/allkaraoke/tests/PageObjects/SongListPage.ts:55:19) at /home/runner/work/allkaraoke/allkaraoke/tests/rate-unfinished-song.spec.ts:173:5 at /home/runner/work/allkaraoke/allkaraoke/tests/rate-unfinished-song.spec.ts:168:3
[firefox] › sing-a-song.spec.ts:39:5 › Sing a song: tests/PageObjects/SongPreviewPage.ts#L69
1) [firefox] › sing-a-song.spec.ts:39:5 › Sing a song › Set game mode ──────────────────────────── Error: Timed out 7000ms waiting for expect(locator).toHaveAttribute(expected) Locator: getByTestId('game-mode-setting') Expected string: "Pass The Mic" Received string: "Cooperation" Call log: - expect.toHaveAttribute with timeout 7000ms - waiting for getByTestId('game-mode-setting') 11 × locator resolved to <span data-focused="true" data-disabled="false" data-e2e-focused="true" data-test="game-mode-setting" data-test-value="Cooperation" class="ews4mmz0 rounded-md shadow-focusable ec-16n5d0e e84wjn51">…</span> - unexpected value "Cooperation" at PageObjects/SongPreviewPage.ts:69 67 | 68 | public async expectGameModeToBe(modeName: string) { > 69 | await expect(this.gameModeSettingsElement).toHaveAttribute('data-test-value', `${modeName}`); | ^ 70 | } 71 | 72 | public get difficultySettingsElement() { at SongPreviewPagePO.expectGameModeToBe (/home/runner/work/allkaraoke/allkaraoke/tests/PageObjects/SongPreviewPage.ts:69:48) at /home/runner/work/allkaraoke/allkaraoke/tests/sing-a-song.spec.ts:80:33 at /home/runner/work/allkaraoke/allkaraoke/tests/sing-a-song.spec.ts:76:3
[chromium] › source-selection.spec.ts:36:5 › Source selection in sing settings: tests/source-selection.spec.ts#L1
1) [chromium] › source-selection.spec.ts:36:5 › Source selection in sing settings › Make sure the input is not monitored anymore if it is not in use Test timeout of 45000ms exceeded.
[chromium] › source-selection.spec.ts:36:5 › Source selection in sing settings: tests/PageObjects/AdvancedConnectionPage.ts#L39
1) [chromium] › source-selection.spec.ts:36:5 › Source selection in sing settings › Make sure the input is not monitored anymore if it is not in use Error: locator.click: Test timeout of 45000ms exceeded. Call log: - waiting for getByTestId('player-0-source') - locator resolved to <span data-focused="false" data-disabled="false" data-e2e-focused="false" data-test="player-0-source" class="e6monco1 rounded-md shadow-focusable ec-1o15t8w e84wjn51">…</span> - attempting click action - waiting for element to be visible, enabled and stable - element was detached from the DOM, retrying at PageObjects/AdvancedConnectionPage.ts:39 37 | 38 | public async togglePlayerMicrophoneSource(playerNumber: number) { > 39 | await this.getPlayerMicSource(playerNumber).click(); | ^ 40 | } 41 | 42 | public getMicInputName(playerNumber: number) { at AdvancedConnectionPagePO.togglePlayerMicrophoneSource (/home/runner/work/allkaraoke/allkaraoke/tests/PageObjects/AdvancedConnectionPage.ts:39:49) at /home/runner/work/allkaraoke/allkaraoke/tests/source-selection.spec.ts:62:40 at /home/runner/work/allkaraoke/allkaraoke/tests/source-selection.spec.ts:60:3
quick-checks: src/modules/Elements/Snow.tsx#L8
Unexpected any. Specify a different type
quick-checks: src/modules/Elements/Snow.tsx#L31
Unexpected any. Specify a different type
quick-checks: src/modules/Elements/Snow.tsx#L44
Unexpected any. Specify a different type
quick-checks: src/modules/Elements/Switcher.tsx#L18
Unexpected any. Specify a different type
quick-checks: src/modules/Elements/Switcher.tsx#L21
Unexpected any. Specify a different type
quick-checks: src/modules/Elements/Switcher.tsx#L28
Unexpected any. Specify a different type
quick-checks: src/modules/Elements/Tooltip.tsx#L34
Unexpected any. Specify a different type
quick-checks: src/modules/GameEngine/Drawing/Elements/ray.ts#L28
Unexpected any. Specify a different type
quick-checks: src/modules/GameEngine/Drawing/Shaders/Shaders.ts#L25
Unexpected any. Specify a different type
quick-checks: src/modules/GameEngine/GameState/PlayerState.ts#L151
Optional chain expressions can return undefined by design - using a non-null assertion is unsafe and wrong
Slow Test: [chromium] › rate-unfinished-song.spec.ts#L1
[chromium] › rate-unfinished-song.spec.ts took 35.5s
Slow Test: [chromium] › duet-song.spec.ts#L1
[chromium] › duet-song.spec.ts took 26.7s
Slow Test: [chromium] › co-op-mode.spec.ts#L1
[chromium] › co-op-mode.spec.ts took 18.8s
Slow Test: [chromium] › convert-and-sing-a-song.spec.ts#L1
[chromium] › convert-and-sing-a-song.spec.ts took 18.7s
Slow Test: [chromium] › mobile-phone-mode.spec.ts#L1
[chromium] › mobile-phone-mode.spec.ts took 18.7s
Slow Test: [firefox] › co-op-mode.spec.ts#L1
[firefox] › co-op-mode.spec.ts took 17.1s
Slow Test: [firefox] › selection-playlist.spec.ts#L1
[firefox] › selection-playlist.spec.ts took 1.5m
Slow Test: [firefox] › remote-song-list.spec.ts#L1
[firefox] › remote-song-list.spec.ts took 54.3s
Slow Test: [firefox] › remote-mics-settings.spec.ts#L1
[firefox] › remote-mics-settings.spec.ts took 23.8s
Slow Test: [firefox] › source-selection.spec.ts#L1
[firefox] › source-selection.spec.ts took 21.6s
Slow Test: [firefox] › remote-mics-playlist.spec.ts#L1
[firefox] › remote-mics-playlist.spec.ts took 16.8s
Slow Test: [chromium] › selection-playlist.spec.ts#L1
[chromium] › selection-playlist.spec.ts took 1.5m
Slow Test: [chromium] › remote-song-list.spec.ts#L1
[chromium] › remote-song-list.spec.ts took 1.0m
Slow Test: [chromium] › remote-mics-sing-a-song.spec.ts#L1
[chromium] › remote-mics-sing-a-song.spec.ts took 34.4s
Slow Test: [chromium] › sing-a-song.spec.ts#L1
[chromium] › sing-a-song.spec.ts took 33.1s
Slow Test: [chromium] › remote-mics-settings.spec.ts#L1
[chromium] › remote-mics-settings.spec.ts took 21.2s
deploy
Skip setting environment url as environment 'production' may contain secret.
🎭 Playwright Run Summary
1 skipped 28 passed (3.7m)
🎭 Playwright Run Summary
1 flaky [firefox] › rate-unfinished-song.spec.ts:54:5 › user can correctly select all of the shown reasons why the song was not completed 6 skipped 22 passed (4.6m)
🎭 Playwright Run Summary
1 flaky [firefox] › sing-a-song.spec.ts:39:5 › Sing a song ───────────────────────────────────────────── 3 skipped 25 passed (5.0m)
🎭 Playwright Run Summary
1 flaky [chromium] › source-selection.spec.ts:36:5 › Source selection in sing settings ───────────────── 1 skipped 27 passed (6.3m)