Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DLSP23] Fixes for torchtext in 12-regularization #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swappysh
Copy link

I was facing some issues with torchtext and Collections iterable, added a pip command to install it and made a backward-compatible support for Collections

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@swappysh swappysh changed the title Fixes for torchtext [DLSP23] Fixes for torchtext Apr 15, 2023
@swappysh swappysh changed the title [DLSP23] Fixes for torchtext [DLSP23] Fixes for torchtext in 12-regularization.ipynb Apr 15, 2023
@swappysh swappysh changed the title [DLSP23] Fixes for torchtext in 12-regularization.ipynb [DLSP23] Fixes for torchtext in 12-regularization Apr 15, 2023
@Atcold
Copy link
Owner

Atcold commented Apr 21, 2023

Are you doing this for extra credit?
If so, we should update to the latest API of torchtext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants