advertisement callback now returns the list of provided namespaces #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimalinux
changed the title
noot
reviewed
Mar 11, 2023
noot
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we had a
ShouldAdvertiseFuncthat wasn't really determining if we should advertise. It was determining if we should advertise additional namespaces on top of the empty namespace.This PR replaces
SetShouldAdvertiseFuncwithSetAdvertisedNamespacesFunc. The new callback returns the list of namespaces that should be advertised including the empty namespace.This PR will be merged first in conjunction with AthanorLabs/atomic-swap#342.