AdvertisedNamespacesFunc is now set during the Host's contructor #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a
SetAdvertisedNamespacesFuncfunction, but it wasn't clear when it should be called. Tests and live code were using it differently. If it was called afterhost.Start(), you'd want it to immediately run the advertisement loop to advertise the latest namespaces. If you allowed it to be called beforehost.Start(), it either couldn't run the advertisement loop, or we would have needed some synchronization soSetAdvertisedNamespacesFuncwould know whether it was safe to run the loop.The more sane solution, implemented here, is to set the function during the
Host's constructor. The behavior of the function can change with time, and there is already an API to run the advertisement loop immediately.