Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeepAlive settings between client and proxy #41

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Add KeepAlive settings between client and proxy #41

merged 4 commits into from
Aug 7, 2024

Conversation

fum1h1to
Copy link
Contributor

@fum1h1to fum1h1to commented Jul 29, 2024 •
edited
Loading

Description

  • add KeepAlive Settings

    • Add a configuration setting to enable/disable KeepAlive between the client and authorization-proxy.

  • config.yaml

version: v2.0.0
server:
  disableKeepAlives: false

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Related issue/PR

Delete this section if there are no issues or pull requests that relate to this pull request.

  • Fixes #issue
  • Closes #PR

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

y-myajima
y-myajima reviewed Aug 5, 2024
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
test/data/example_config.yaml Outdated Show resolved Hide resolved
ly-2045544 and others added 4 commits August 5, 2024 17:45
@fum1h1to
fix: switch server keepAlives
d9fc88b 
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
@fum1h1to
fix: test
115e8b7 
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
@fum1h1to
fix: disableKeepAlives comment
77bd5aa 
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
@fum1h1to
fix: review
2cc146e 
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
@fum1h1to fum1h1to force-pushed the feature/client-to-proxy-keepalive branch from fa1ff08 to 2cc146e Compare August 5, 2024 08:46
@fum1h1to fum1h1to marked this pull request as ready for review August 5, 2024 08:48
y-myajima
y-myajima approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@y-myajima y-myajima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fum1h1to fum1h1to merged commit 4bc56bb into master Aug 7, 2024
2 checks passed
@fum1h1to fum1h1to deleted the feature/client-to-proxy-keepalive branch August 7, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-myajima y-myajima y-myajima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fum1h1to @y-myajima