Bug Fixed

AtikulSoftware · Mar 8, 2024 · 6200c53 · 6200c53
1 parent e4207d9
commit 6200c53
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 11 deletions.
diff --git a/SmartAdmob-release.aar b/SmartAdmob-release.aar
diff --git a/SmartAdmob/build.gradle b/SmartAdmob/build.gradle
@@ -76,7 +76,7 @@ publishing {
         maven(MavenPublication) {
             groupId = 'com.github.AtikulSoftware'
             artifactId = 'SmartAdmob'
-            version = "3.0"
+            version = "4.0"
             pom {
                 description = 'Smart Admob Library'
             }

diff --git a/SmartAdmob/src/main/java/com/bdtopcoder/smartadmob/AdmobAd.java b/SmartAdmob/src/main/java/com/bdtopcoder/smartadmob/AdmobAd.java
@@ -49,7 +49,6 @@ public AdmobAd() {
     public AdmobAd initializeAdmobAd() {
         if (AdmobAdUnit.ADMOB_AD_IS_ON) {
             MobileAds.initialize(activity, initializationStatus -> {
-                admobAdCallBack.adInitialize(initializationStatus);
             });
         }
         return this;

diff --git a/SmartAdmob/src/main/java/com/bdtopcoder/smartadmob/AdmobAdCallBack.java b/SmartAdmob/src/main/java/com/bdtopcoder/smartadmob/AdmobAdCallBack.java
@@ -21,8 +21,6 @@ default void onAdLoaded() {}
 
     default void onAdOpened() {}
 
-    default void adInitialize(InitializationStatus initializationStatus) {}
-
     // Interstitial Ad
     default void onAdLoaded(InterstitialAd interstitialAd){}
     default void onAdDismissedFullScreenContent(){}

diff --git a/SmartAdmob/src/main/java/com/bdtopcoder/smartadmob/GDPR.java b/SmartAdmob/src/main/java/com/bdtopcoder/smartadmob/GDPR.java
@@ -3,6 +3,7 @@
 import android.app.Activity;
 import android.util.Log;
 
+import com.google.android.gms.ads.MobileAds;
 import com.google.android.ump.ConsentForm;
 import com.google.android.ump.ConsentInformation;
 import com.google.android.ump.ConsentRequestParameters;
@@ -55,7 +56,6 @@ private void initializeMobileAdsSdk() {
         if (isMobileAdsInitializeCalled.getAndSet(true)) {
             return;
         }
-
         AdmobAd admobAd = new AdmobAd(activity);
         admobAd.initializeAdmobAd();
 

diff --git a/app/build.gradle b/app/build.gradle
@@ -11,7 +11,7 @@ android {
         minSdk 19
         targetSdk 34
         versionCode 1
-        versionName "3.0"
+        versionName "4.0"
         multiDexEnabled true
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

diff --git a/app/src/main/java/com/bdtopcoder/smartadmob/MainActivity.java b/app/src/main/java/com/bdtopcoder/smartadmob/MainActivity.java
@@ -15,15 +15,20 @@ protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_main);
 
+        // set admob ad unit id
+        AdmobAdUnit.ADMOB_BANNER_AD = "ca-app-pub-3940256099942544/9214589741";
+
+        // gdpr msg
         GDPR gdpr = new GDPR(this);
         gdpr.setGDPR();
 
-        // Banner Ad
         AdmobAd admobAd = new AdmobAd(this);
-        admobAd.loadBanner(findViewById(R.id.adLayout));
-
 
+        // sdk initialize
+        admobAd.initializeAdmobAd();
 
+        // Banner Ad
+        admobAd.loadBanner(findViewById(R.id.adLayout));
 
 
     }

diff --git a/jitpack.yml b/jitpack.yml
@@ -4,4 +4,4 @@ before_install:
   - ./scripts/prepareJitpackEnvironment.sh
 install:
   - FILE="-Dfile=SmartAdmob-release.aar"
-  - mvn install:install-file $FILE -DgroupId=com.github.AtikulSoftware -DartifactId=SmartAdmob -Dversion=3.0 -Dpackaging=aar -DgeneratePom=true
+  - mvn install:install-file $FILE -DgroupId=com.github.AtikulSoftware -DartifactId=SmartAdmob -Dversion=4.0 -Dpackaging=aar -DgeneratePom=true
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.github.AtikulSoftware</groupId>
     <artifactId>SmartAdmob</artifactId>
-    <version>3.0</version>
+    <version>4.0</version>
     <packaging>pom</packaging>
     <description>Smart Admob Library</description>
 </project>