Set output_encoding to iso-8859-1 for properties configs #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Guatemala deployment we notice that its organization name is not correctly encoded:
https://snib.conap.gob.gt/registros/#tab_simpleSearch
this is because
propertiesshould be encoded iniso-8859-1to allow use of non-latin characters, seehttps://stackoverflow.com/questions/37436927/utf-8-encoding-of-application-properties-attributes-in-spring-boot
this doesn't happen with yml configs.
This patch add
output_encoding=iso-8859-1to the main ALA modules that still usepropertiesas config.We didn't have this problem because, for instance, in Spain we use latin characters for our OrgName etc.
Tested with orgName in:
https://collections.l-a.site/
https://species.l-a.site/
Also related: #381