Configurable skin layouts per services #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djtfmartin
approved these changes
Oct 19, 2020
vjrj
added a commit
to living-atlases/generator-living-atlas
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When several services are deployed in the same VM, the variable
skin_layoutare not set correctly for each different service.For some reason we lost this commit 7f2ede9 in the collectory configuration that address this problem partially.
But I also added similar variables to the rest of main services as I noticed that this was not working when mixing services in a VM.
This should not affect previous inventories (like the ALA inventories) that do not use these new variables and still use a basic
skin_layoutin each of their inventories.The LA inventories generator it's ready to use these variables living-atlases/generator-living-atlas@27724bf and I tested the deployment in
18.04VMs.PS: I did a summary of layouts used in: https://docs.google.com/spreadsheets/d/19rs1GuxZX2tRfm2x8YYf83fAcBrIG1gObIqVOV6C870/edit?usp=sharing