Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Your Area fails to render if logger service is unavailable #611

Open
nickdos opened this issue Aug 15, 2024 · 1 comment · Fixed by #612
Open

Explore Your Area fails to render if logger service is unavailable #611

nickdos opened this issue Aug 15, 2024 · 1 comment · Fixed by #612
Milestone

Comments

@nickdos
Copy link
Contributor

nickdos commented Aug 15, 2024

EYA page includes _download.gsp that uses a getLoggerReasons taglib:

<g:each var="it" in="${alatag.getLoggerReasons()}">
    <option value="${it.id}">${it.name}</option>
</g:each>

When logger service is offline, the getLoggerReasons() method generates an exception that prevents the entire page from loading.

Fix is to catch the exception and insert either a dummy list (same data structure as logger reasons) with the error message or use a fall-back list of reasons from the config file.

Further investigation revealed that this code is only used by the legacy download (modal UI) and the ALA download is handled by the downloads-plugin code.

@nickdos
Copy link
Contributor Author

nickdos commented Aug 16, 2024

Tested with both config settings:

useDownloadPlugin=true
useDownloadPlugin=false

and setting an invalid URL for logger service to emulate the server being down.

In all cases, the EYA page will work - downloads will still fail when logger is not available.

See screenshot for false case:

image

@nickdos nickdos linked a pull request Aug 16, 2024 that will close this issue
@nickdos nickdos added this to the 7.1.1 milestone Aug 16, 2024
nickdos added a commit that referenced this issue Aug 16, 2024
…fails-to-render-if-logger-service-is-unavailable

#611 Fix for logger service being unavailable
@nickdos nickdos reopened this Aug 16, 2024
@nickdos nickdos changed the title Fix: EYA page fails to render if logger service is unavailable Explore your area fails to render if logger service is unavailable Aug 16, 2024
@nickdos nickdos changed the title Explore your area fails to render if logger service is unavailable Explore Your Area fails to render if logger service is unavailable Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant