Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtmosphereRequest.getParameter should check for isNotNoOps() #326

Closed
renarsg opened this issue May 1, 2012 · 4 comments
Closed

AtmosphereRequest.getParameter should check for isNotNoOps() #326

renarsg opened this issue May 1, 2012 · 4 comments

Comments

@renarsg
Copy link

renarsg commented May 1, 2012

This line:
String name = b.request == null ? null : b.request.getParameter(s);

Shoud probably be like this:
String name = isNotNoOps() ? null : b.request.getParameter(s);

Otherwise the getParameter doesn't work for cases where request is not set (b.request is never null)

@jfarcand
Copy link
Member

jfarcand commented May 1, 2012

Looking

@jfarcand
Copy link
Member

jfarcand commented May 1, 2012

Agree. integrated.

@jfarcand jfarcand closed this as completed May 1, 2012
@renarsg
Copy link
Author

renarsg commented May 3, 2012

sorry, actually it should be otherway around:
String name = isNotNoOps() ? b.request.getParameter(s) : null;

jfarcand added a commit that referenced this issue May 3, 2012
@jfarcand
Copy link
Member

jfarcand commented May 3, 2012

OUF...I need vacation :-) Fixed! Thanks!!!!

jfarcand added a commit that referenced this issue May 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants