Undefined variables in jquery.atmosphere.js

[hpihkala]

If I add a custom header for the request and define it as a function, like this:

        var request = { 
                /* ... */
                headers: {
                    c: function() {
                        return counter;
                    }
                }
        };

jquery.atmosphere.js fails in function _attachHeaders(request):

                jQuery.each(rq.headers, function(name, value) {
                    var h = jQuery.isFunction(value) ? value.call(this, ajaxRequest, request, create) : value;
                    if (h) {
                        url += "&" + encodeURIComponent(name) + "=" + encodeURIComponent(h);
                    }
                });

Where it tries to call the function with parameters (this, ajaxRequest, request, create). As far as I can see both ajaxRequest and create are undefined and the browser throws an error.

Variables with these names are not available even in the functions that _attachHeaders() is called from, so maybe they are some old stuff from before the rewriting of the jquery plugin? Maybe they can just be removed from the function call?

Best regards,
Henri

[hpihkala]

You should also change the line

if (h) {

to

if (h!=null) {

Because the value of h might well be a valid value of 0, which evaluates to false and does not get added.

[hpihkala]

All of the above was in _attachHeaders(request). Actually a similar piece of code exists in function _doRequest(ajaxRequest, request, create) where the variables ajaxRequest and create DO exist.

However the comment about the "if (h)" applies to _doRequest() function also!

[jfarcand]

Can you do a pull request so I can integrate easily your proposal? If not, just cut an paste a diff -u to this thread. Thanks

[jfarcand]

Testing the fix.

[jfarcand]

Integrated. Thanks