Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmosphere Server on Android Compatibility #503

Closed
mvysny opened this issue Jul 12, 2012 · 3 comments
Closed

Atmosphere Server on Android Compatibility #503

mvysny opened this issue Jul 12, 2012 · 3 comments

Comments

@mvysny
Copy link
Contributor

mvysny commented Jul 12, 2012

What steps will reproduce the problem?

  1. Start the Atmosphere server on Android (packed with Jetty in APK)

What is the expected output? What do you see instead?
Atmosphere XML parser crashes with NPE

What version of the product are you using? On what operating system?
0.9.7 on Android

Please provide any additional information below.
The exception is raised in AtmosphereConfigReader:147 - the Attr DOM node does not have any child nodes (according to DOM specification), therefore attribute.getFirstChild() returns null. It is interesting though that it works on a regular Java - it should fail as well.
The fix is simple: replace attribute.getFirstChild().getNodeValue() with attribute.getNodeValue() - this fixes the issue both on regular Java and on Android Java.
With this patch, I have verified that the server works properly on Android
This bug was originally submitted here: http://code.google.com/p/atmosphere-gwt-comet/issues/detail?id=16

@jfarcand
Copy link
Member

Fixed. If you have a chance, use a recent SNAPSHOT to test the fix and let me know. Thanks!!!

@mvysny
Copy link
Contributor Author

mvysny commented Jul 13, 2012

Thank you for such a quick fix! I tried 1.0.0-SNAPSHOT but I encountered a different bug: #506

@mvysny
Copy link
Contributor Author

mvysny commented Jul 13, 2012

I found a workaround for #506 and now I can confirm that this issue is fixed and the server works on Android. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants