Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[atmosphere.js] when unsubscribe, if request url contains search key, push close event will cause problems #942

Closed
oliver456 opened this issue Mar 1, 2013 · 4 comments
Closed

[atmosphere.js] when unsubscribe, if request url contains search key, push close event will cause problems #942

oliver456 opened this issue Mar 1, 2013 · 4 comments
Labels
1.0.12

Comments

@oliver456
Copy link

see https://github.com/Atmosphere/atmosphere/blob/master/modules/jquery/src/main/webapp/jquery/jquery.atmosphere.js#L2432
@jfarcand
Copy link
Member

jfarcand commented Mar 1, 2013

Can you elaborate? What do you means by search key?

@oliver456
Copy link
Author

eg : if original request url is localhost:8080/query?f=230, when client unsubscribe and push close event, the ajax url will change to "localhost:8080/query?f=230?X-Atmosphere-Transport=close&X-Atmosphere-tracking-id=32e8ad16-6a84-44de-9b2d-f86bc93c089a" ,that cause server can not close this seesion correctly.

jfarcand added a commit that referenced this issue Mar 1, 2013
@jfarcand
Fix for #942 #944
3d9ca68
@jfarcand
Copy link
Member

jfarcand commented Mar 1, 2013

Fixed, can you try it and report? Thanks

@jfarcand jfarcand closed this as completed Mar 1, 2013
jfarcand added a commit that referenced this issue Mar 1, 2013
@jfarcand
Fix for #942 #944
b078453
@oliver456
Copy link
Author

run ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliver456 @jfarcand