This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Update for Linter v2 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what the previous configuration was, as the versions weren't defined in the package.json, but it looked ancient. Update to the current style guide used in most other projects in this org.
Move the configuration to a configSchema key in package.json so Atom doesn't have to parse and run the package code to know what settings are available for it.
Update the minimap consumer code to match the current practices.
|
Note, as far as I can see from debugging this, it should be working, but no markers are showing up in the minimap and I'm not entirely sure what is wrong. |
Arcanemagus
force-pushed
the
arcanemagus/cleanup
branch
from
1dd9eac
to
f04a6bf
Compare
|
With some help from @abe33 on how |
Provide a Linter "UI" so we are given all new messages from the Linter. Using these messages, generate markers of our own and decorate them with minimap.
Arcanemagus
force-pushed
the
arcanemagus/cleanup
branch
from
f04a6bf
to
fc32f7d
Compare
steelbrain
reviewed
Mar 22, 2017
spec/atom-minimap-linter-spec.js
Outdated
| let editor; | ||
| let minimap; | ||
|
|
||
| beforeEach(() => { |
There was a problem hiding this comment.
import { beforeEach } from 'jasmine-fix'
and then you'll be able to do beforeEach(async function(){
Arcanemagus
force-pushed
the
arcanemagus/cleanup
branch
from
2eac958
to
c4e83e9
Compare
If a user somehow doesn't already have Linter installed when they installed this package, install it for them. Mainly added to bring in the requirement of Linter v2 as this package will no longer work with Linter v1 after this gets released.
As these classes are just being used for the color, and can be used on multiple different marker types, simplify the name a bit.
IANAL so I have no idea if "AtomLinter" works for the name.
* Specify the full path to the main file * Update the description * Fill in some keywords * Mark as private to prevent accidental NPM publishings
Arcanemagus
force-pushed
the
arcanemagus/cleanup
branch
from
c4e83e9
to
8a3eadd
Compare
Add a configuration for CircleCI builds.
Linter fixed a bug in v2.1.1 so now newly added UI providers are given any messages registered before they were activated as their first `added` batch. This means we can always just use `added` and `removed`.
Arcanemagus
force-pushed
the
arcanemagus/cleanup
branch
from
abf4032
to
0ab75da
Compare
This was referenced Mar 22, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to work with Linter v2. Creates a UI provider for Linter v2 so it will feed us all the messages, allowing us to manage the markers ourselves instead of trying to intercept the markers from Linter.