Add support for $PROJECT substitution #143
Conversation
| @@ -170,6 +181,7 @@ module.exports = | |||
| parameters.push('-') | |||
|
|
|||
| execPath = atom.config.get('linter-flake8.executablePath') | |||
| execPath = applySubstitutions(execPath) | |||
There was a problem hiding this comment.
Why not just combine this into the line above?
|
Sorry it took so long to get to reviewing this! |
| @@ -144,6 +144,17 @@ module.exports = | |||
| provideLinter: -> | |||
| helpers = require('atom-linter') | |||
| path = require('path') | |||
There was a problem hiding this comment.
To make stuff simpler, we could make this Path and then use path to store path value below
|
Any better? |
|
LGTM, any further comments @steelbrain? |
|
Does this project has specs? If it does, it would be nice to have one for this PR. Otherwise, you have my go if it works |
|
It does, and that's an excellent idea 😉. |
|
@keras Rebase and add specs and I would love to merge this 😉. |
keras
changed the title
|
It would be very great to have |
|
Sorry @keras, didn't see that you had added the specs! I'll merge this in now and push out a release. |
Add support for $PROJECT substitution
|
Published as v1.12.0. 🎉 |
ghost
mentioned this pull request
Copied functionality from https://github.com/sadovnychyi/autocomplete-python to add support for project-specific flakes with
$PROJECTor$PROJECT_NAMEsubstitutions for project specific paths e.g.$PROJECT/.venv/bin/flake8.