This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Rewrite in ES2017 #255
Merged
Rewrite in ES2017 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite in ES2017, including: * Rename `pep8ErrorsToWarnings` to pycodestyleErrorsToWarnings` * Move the range modification code into a separate file * Remove most of the range fixers in favor of `rangeFromLineNumber`'s "word" highlighting as it has the same effect in all removed cases. * Fix the remaining range fixing code to actually work properly * Set the minimum Atom version to v1.9.0 since we have tight version restrictions as we are using unpublic code parts * Move the configuration to a `configSchema` in the package.json * Install `hacking` in CI to test the custom range highlighting as half the code is to deal with issues it presents * Observe all settings * Use `helpers.rangeFromLineNumber` where possible * Use `async`/`await` to simplify the code where possible * Fix a race condition where the editor contents have changed since the lint was triggered * Convert `projectConfigFile` to an array. This is largely transparent as it was already being handled like one, this just means Atom handles stripping whitespace for us
This was referenced Oct 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite in ES2017, including:
pep8ErrorsToWarningstopycodestyleErrorsToWarningsrangeFromLineNumber's "word" highlighting as it has the same effect in all removed cases.configSchemain the package.jsonhackingin CI to test the custom range highlighting as half the code is to deal with issues it presentshelpers.rangeFromLineNumberwhere possibleasync/awaitto simplify the code where possibleprojectConfigFileto an array. This is largely transparent as it was already being handled like one, this just means Atom handles stripping whitespace for us