Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Updates and maintenance #145

Merged
merged 4 commits into from
Oct 17, 2016
Merged

Updates and maintenance #145

merged 4 commits into from
Oct 17, 2016

Conversation

Arcanemagus
Copy link
Member

Fixes a few bugs including:

  • Properly disposing of the subscriptions
  • Stop trying to mark the editor when the contents have changed since the lint was triggered, this could lead to false positives on the "invalid range" check.

Also simplifies the code by utilizing async/await, and moves to lazily requiring the modules that aren't built into the environment.

Simplify the flow of the code quite a bit by using async/await.
Make it so if the editor contents have changed between when the lint was
triggered and the results came back we simply tell Linter to not update
the current messages, instead of attempting to mark up the contents based
on the old (potentially leading to "invalid" ranges, that _were_ valid when
the lint was triggered).
@Arcanemagus Arcanemagus merged commit 4fa53e0 into master Oct 17, 2016
@Arcanemagus Arcanemagus deleted the maintenance branch October 17, 2016 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant