rewrite with ES2015

[1000ch]

This should be reviewed & tested before merging...

ping: @Arcanemagus @johnwebbcole @steelbrain

[Arcanemagus]

Add a .gitattributes that forces LF EOL as well, or Windows clients will check out the files with CRLF, then the .editorconfig will change them to LF on open... leading to the entire file being "different".

[Arcanemagus]

The correct URL is https://github.com/atom-community/linter, also it's just "Linter".

[Arcanemagus]

I think that's all for now, it would be nice if we could get specs added as well, but I'm okay with that being a separate PR for now.

[1000ch]

I think that's all for now, it would be nice if we could get specs added as well, but I'm okay with that being a separate PR for now.

Yes, should be added. I'll send a PR to add specs later.

[Arcanemagus]

If you want an example of what I was talking about, here is one that I recently wrote.

What you have here will work though if you change the last part to:

If [Linter] is not installed, it will be installed for you.

[Arcanemagus]

This should just be [Linter] to use your single defined URL down below 😉.

[1000ch]

Oops...!

[Arcanemagus]

@johnwebbcole Any comments?

[johnwebbcole]

I like the move to JS, I think we should also have a pull request for the Linter API to include a JS plugin example to go with the existing CS example. That way someone who is looking for the Linter way of doing things will also have a JS example.

Has anyone confirmed that APM loads the Linter dependency if it's not already installed? Earlier versions didn't, which was why those instructions were in the readme. If it does, great!

Lets bump the version up to 0.3 too, in case someone wants to live on the CS version.

I haven't had a chance to use bable yet, but have been wanting too. Are there any changes to the build/deploy process?

I'll try the branch out tonight.

[steelbrain]

@johnwebbcole I've already updated the Linter API wiki page to have a JS provider a long time ago

[Arcanemagus]

With other plugins we've bumped the major version number when a complete re-write has been done, just in case.

As for babel, inside Atom directly you don't need to do anything special, but if you are spawning an external thread (such as the worker process in linter-eslint) it needs to be ES5 only apparently.

@steelbrain could tell you more as I've mainly worked directly in Atom so far.

[steelbrain]

@Arcanemagus Yes that's true, Atom intercepts each require and tries to compile it if it's a babel file but if it's on a spawned or even forked node process, it won't setup those compilation hooks. and to overcome the storage limitations of APM, you'll have to keep compiled babel files in the repo

[Arcanemagus]

@johnwebbcole the "package-deps" section, plus the require('atom-package-deps).install() in the activate section are what automatically install the Linter package.

I've had AtomLinter/Meta#8 open for a while regarding a "template" package, but haven't had a chance to actually implement it yet.

Anyone have a reason this shouldn't be merged? LGTM currently, assuming it works 😛.

[steelbrain]

Just a side note that this will break in the future versions of node because they don't export a default for you to use here, either do

import * as path from 'path'

or do

import {dirname as getDirNameFromPath} from 'path'

^ add anything you wanna import there

[steelbrain]

Overall, @1000ch I like what you did here. Good job 👍

[1000ch]

@steelbrain Also fixed provideLinter() & squashed commits 👍

[steelbrain]

LGTM

[Arcanemagus]

Merging it in since nobody else seems to be doing so 😛.

Wwe can fix any remaining issues from there.

[1000ch]

I just published v0.3.0. I will publish v1.0.0 after adding specs.