Wrong path to htmlhint

[AnWeber]

the issue #65 is produced to the wrong path to the htmlhint file. My previous fix attempt by changing to exec instead of execNode was just a workaround. I didn't notice the wrong path.

[johnwebbcole]

The .bin directory should be there... What OS are you on? It seems APM moves executables to a common directory.

[Arcanemagus]

apm and npm both should be creating that path, the issue was simply exec vs execNode as you originally surmised.

What version of Atom are you using?

[Arcanemagus]

Just looked over the rest of the comments in #65, and then checked on the htmlhint "executable" scripts in this folder. They assume you have node installed, which isn't necessarily valid for all Atom users.

So although this is the "wrong" path for executing the htmlhint "binary", it's the right path for our case. Before this gets merged @AnWeber can you update the description of the setting to note that this is the node script, not the executable?

Something like: "HTMLHint Node executable" is probably enough to hint as to which one that should be chosen.

[AnWeber]

I am using Windows 10 and Atom 1.4. NodeJS was installed while installing the plugin. Afterwards I uninstalled NodeJS to test the issue without NodeJS installed.
@Arcanemagus the new path is also the executable. The script would bin in htmlhint/lib/htmlhint.js.

[Arcanemagus]

@AnWeber:

// This is the wrapper script ("system binary") which requires node to be installed
path.join(__dirname, '..', 'node_modules', '.bin', 'htmlhint');

// This is the node executable script, which Atom can run and the above are wrappers around
path.join(__dirname, '..', 'node_modules', 'htmlhint', 'bin', 'htmlhint');

// This is the (minified) htmlhint script itself, and is not executable unless ran through something
path.join(__dirname, '..', 'node_modules', 'htmlhint', 'lib', 'htmlhint.js');

[AnWeber]

thanks for clarification. I changed the name of the setting to 'HTMLHint Node Script Path'

[Arcanemagus]

Push it up, and assuming @johnwebbcole has no comments we can get it merged 😉.

[AnWeber]

Ready. I forgot to push

[johnwebbcole]

It's ok with me... The original script used the bin, not the .bin. I like the .bin idea, but it doesn't look like it's valid on all platforms

[Arcanemagus]

Looks like Atom didn't get added to the PATH in the AppVeyor build for some reason, pinged @steelbrain to rebuild that then we can merge.