Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

2 deprecations warnings with current API #14

Closed
jplatte opened this issue May 4, 2015 · 6 comments
Closed

2 deprecations warnings with current API #14

jplatte opened this issue May 4, 2015 · 6 comments
Labels

Comments

@jplatte
Copy link

jplatte commented May 4, 2015

Since some versions (currently I'm on 0.196.0) I'm getting 2 warnings about linter-javac from Deprecation Cop:

(1)

Use a config schema instead. See the configuration section of https://atom.io/docs/latest/hacking-atom-package-word-count and https://atom.io/docs/api/latest/Config for more details

Package.activateConfig - /usr/share/atom/resources/app.asar/src/package.js:247:11
Package.activateNow - /usr/share/atom/resources/app.asar/src/package.js:218:14
<unknown> - /usr/share/atom/resources/app.asar/src/package.js:203:30
Package.measure - /usr/share/atom/resources/app.asar/src/package.js:147:15

(2)

Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands - /usr/share/atom/resources/app.asar/src/package.js:790:9
Package.hasActivationCommands - /usr/share/atom/resources/app.asar/src/package.js:715:20
<unknown> - /usr/share/atom/resources/app.asar/src/package.js:169:24
Package.measure - /usr/share/atom/resources/app.asar/src/package.js:147:15
@brampersandon
Copy link
Contributor

Hi jplatte!

It looks like these deprecations are in atom core, not the linter-javac package.
screen shot 2015-05-04 at 8 30 27 am

You can tell which package is causing the deprecation warnings based on the dropdown menu that contains them.

@jplatte
Copy link
Author

jplatte commented May 4, 2015

screenshot from 2015-05-04 16-33-40

@brampersandon
Copy link
Contributor

Nice! I stand corrected. See the attached PR (you can apply it to your own install if you like!) for a resolution.

@jplatte
Copy link
Author

jplatte commented May 5, 2015

Thanks! (though I'll wait for the next release, the small warning icon isn't much of a problem 😄)

@brampersandon
Copy link
Contributor

Totally. :)

To be honest, I'm not 100% certain this repo is still being maintained(?) There are gobs of stale PR's and issues hanging out here...

@florianb, are you still the core committer?

kevinsawicki added a commit that referenced this issue May 22, 2015
Repaired 2 deprecation cop errors per #14
@kevinsawicki
Copy link
Member

Fixed by #15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants