Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Support classpath configuration via .classpath files. #30

Merged
merged 3 commits into from
Aug 11, 2015
Merged

Support classpath configuration via .classpath files. #30

merged 3 commits into from
Aug 11, 2015

Conversation

daw42
Copy link
Contributor

@daw42 daw42 commented Aug 7, 2015

This PR allows for configuration of the classpath on a per-project basis via .cson files. The user can place a .linter-javac.cson file within their project and the linter will use the classpath that is provided within the file.

Additionally, it will execute the javac command in the directory of the .cson file so it is possible to use paths that are relative to the .cson configuration file.

  • README.md updated with documentation
  • Requires season for CSON parsing

This makes it much more convenient to configure different classpaths for each project.

@keplersj
Copy link
Contributor

keplersj commented Aug 7, 2015

Linter clang used to do something similar and it was not helpful in the
long run.

I would much prefer if a .classpath file like that used by linter-scalac
could be used by this.

On Thu, Aug 6, 2015, 7:37 PM daw42 notifications@github.com wrote:

This PR allows for configuration of the classpath on a per-project basis
via .cson files. The user can place a .linter-javac.cson file within
their project and the linter will use the classpath that is provided within
the file.

Additionally, it will execute the javac command in the directory of the
.cson file so it is possible to use paths that are relative to the .cson
configuration file.

  • README.md updated with documentation
  • Requires season for CSON parsing

This makes it much more convenient to configure different classpaths for

each project.

You can view, comment on, or merge this pull request online at:

#30
Commit Summary

  • Support classpath configuration via cson files.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#30.

@daw42
Copy link
Contributor Author

daw42 commented Aug 7, 2015

Hi @k2b6s9j, I looked at the linter-scalac repo, and it looks very similar to what this PR does. The only significant difference is that I'm using CSON, and they use a flat file. The advantage of CSON is that we can expand to support more configuration in the future if necessary.

@keplersj
Copy link
Contributor

keplersj commented Aug 7, 2015

I understand that. But the problem is that this file only supports the
Scala Linter for Atom. We should not be trying to create a new standard
where there is already one, especially where the JVM is concerned.

On Fri, Aug 7, 2015, 2:29 PM daw42 notifications@github.com wrote:

Hi @k2b6s9j https://github.com/k2b6s9j, I looked at the linter-scalac
repo, and it looks very similar to what this PR does. The only
significant difference is that I'm using CSON, and they use a flat file.
The advantage of CSON is that we can expand to support more configuration
in the future if necessary.


Reply to this email directly or view it on GitHub
#30 (comment)
.

@daw42
Copy link
Contributor Author

daw42 commented Aug 7, 2015

I understand that. But the problem is that this file only supports the
Scala Linter for Atom.

Did you mean the javac linter?

Ok, I'll update to use .classpath

@keplersj
Copy link
Contributor

keplersj commented Aug 7, 2015

Sorry. Yes I meant that. Thank you.

On Fri, Aug 7, 2015, 2:44 PM daw42 notifications@github.com wrote:

I understand that. But the problem is that this file only supports the
Scala Linter for Atom.

Did you mean the javac linter?

Ok, I'll update to use .classpath


Reply to this email directly or view it on GitHub
#30 (comment)
.

@daw42
Copy link
Contributor Author

daw42 commented Aug 7, 2015

Updated, thanks.

@daw42 daw42 changed the title Support classpath configuration via cson files. Support classpath configuration via .classpath files. Aug 8, 2015
@daw42
Copy link
Contributor Author

daw42 commented Aug 10, 2015

Do you need anything else in order to merge this?

Thanks.

@steelbrain
Copy link
Contributor

@k2b6s9j has been busy throughout the weekend I think. He'll have a look into this soon, hopefully.

@keplersj
Copy link
Contributor

Awesome! This will be in the next minor update!

keplersj added a commit that referenced this pull request Aug 11, 2015
Support classpath configuration via .classpath files.
@keplersj keplersj merged commit 6339b5f into AtomLinter:master Aug 11, 2015
@daw42 daw42 deleted the classpath_cson branch August 11, 2015 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants