This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Rewrite in JS #41
Merged
Rewrite in JS #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 1, 2017 18:11
|
Some problem with the package activation: |
|
Taken care of, can you please try again? |
|
Sorry, I was busy earlier. Still the error with installation remains: |
|
That is purely a network or ISP interception issue. Can you try manually installing the Linter v2? That error should not affect the end users of this package in any way |
|
I ran: Press Ctrl - Shift - P: Update Package Dependencies: Update and after the restart the installer start installing dependencies. Now I'm debugging why the lintserver doesn't want start. |
TeroFrondelius
suggested changes
Apr 2, 2017
lib/server.js
Outdated
| export async function getPipePath(): Promise<{ subscription: CompositeDisposable, path: string }> { | ||
| const subscription = new CompositeDisposable() | ||
| let path = await new Promise(function(resolve, reject) { | ||
| tmp.file(function(error, tempPath, fd, cleanupCallback) { |
There was a problem hiding this comment.
I guess tmp.file creates a temporary file. Unfortunately this won't work, because the lintserver() wants to create the file and cannot, if the file already exists:
julia> a = "/tmp/tmp-17077g9zhwjrfaehc.tmp"
"/tmp/tmp-17077g9zhwjrfaehc.tmp"
shell> ls $a
ls: cannot access /tmp/tmp-17077g9zhwjrfaehc.tmp: No such file or directory
shell> touch $a
shell> ls $a
/tmp/tmp-17077g9zhwjrfaehc.tmp
julia> lintserver(a,"standard-linter-v2")
ERROR: ArgumentError: could not listen on path /tmp/tmp-17077g9zhwjrfaehc.tmp
in listen(::String) at ./stream.jl:944
in lintserver(::String, ::String) at /home/tero/.julia/v0.5/Lint/src/Lint.jl:468
shell> rm $a
julia> lintserver(a,"standard-linter-v2")
Server running on port/pipe /tmp/tmp-17077g9zhwjrfaehc.tmp ...
^CServer closed
shell> ls $a
ls: cannot access /tmp/tmp-17077g9zhwjrfaehc.tmp: No such file or directoryIt looks that if lintserver closes properly it will clean the temporary file as well.
There was a problem hiding this comment.
Acknowledged, didn't know that. Working on a fix
TeroFrondelius
approved these changes
Apr 2, 2017
|
Really nice work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, contains a rewritten package with Linter v2 support general bugfixes and Flow/ESLint with Circle CI configuration