Fixed a couple of things, details in commits #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2018 15:57
There was a bug in post.js were this.rating would be undefined,
this would result in the code crashing on this.rating.charAt(0)
Also derpibooru didn't have api key support, so now you can add your key
to the search options: {derpikey: "somekey"}
Sites.json: removed the % from derpibooru random since it was not working with it, it does work without and is completely random. Booru.js: actually save the credentials Derpibooru.js: change name of credentials argument also commented out some weird shit for random posts index.js: parse the credentials argument also from here to the booru package-lock.json: npm just really wanted to change this
That was because I forgot to add a When I get time I'll look over how the boorus deal with credentials and see if we can just use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And here we go, ma 3rd pull request.
Somehow these bois cant automatically merge and I don't know why.
I just added and change a couple things, mainly to fix derpibooru.
It works now. (at least for me)