This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Custom bg names #120
Open
Custom bg names #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to elaborate this let's you configure if users can set whatever they want as backgrounds or only bgd from the background list, per area |
oldmud0
suggested changes
May 12, 2021
Comment on lines
+761
to
764
| item['background'], item['bglock'], item['custom_bg_allowed'], | ||
| item['evidence_mod'], item['locking_allowed'], | ||
| item['iniswap_allowed'], | ||
| item['showname_changes_allowed'], |
There was a problem hiding this comment.
Actually now that this was changed, I think you can actually get away with doing
self.Area(self.cur_id, self.server, **item)and then the default parameters set in item just above become redundant.
| @@ -410,8 +412,7 @@ def change_background(self, bg: str): | |||
| Raises: | |||
| AreaError: if `bg` is not in background list | |||
| """ | |||
|
|
|||
| if bg.lower() not in (name.lower() | |||
| if self.custom_bg == False or bg.lower() not in (name.lower() | |||
There was a problem hiding this comment.
Will always say "invalid background name" if custom backgrounds is set to false.
Suggested change
| if self.custom_bg == False or bg.lower() not in (name.lower() | |
| if not self.custom_bg and bg.lower() not in (name.lower() |
Crystalwarrior
referenced
this pull request
in Crystalwarrior/KFO-Server
Feb 11, 2022
* Basic processing * Basic functionality * Add /charlog * Add character showname checking logic * Add character details to client info * Bump up version * Make commands support char showname+Standardize /whois identifier type lookup priority
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is configurable