Skip to content

Commit

Permalink
fix(coffee): fix completion bug on missing coffee command (ohmyzsh#…
Browse files Browse the repository at this point in the history
…10759)

This commit fixes the error

  _coffee:49: bad math expression: operand expected at `< 2 '

when the coffee command is missing or the `coffee --version` command fails.

It also uses is-at-least to check for the cut-off version for suggesting
`--lint` and `--require` arguments, instead of using `cut` multiple times.

Fixes ohmyzsh#10759
  • Loading branch information
mcornella committed Mar 7, 2022
1 parent 93b348b commit 9350e1f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions plugins/coffee/_coffee
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@
#
# ------------------------------------------------------------------------------

local curcontext="$curcontext" state line ret=1 version opts first second third
local curcontext="$curcontext" state line ret=1 version
local -a opts
typeset -A opt_args
version=(${(f)"$(_call_program version $words[1] --version)"})
version=(${(f)"$(_call_program version $words[1] --version)"}) || return ret
version=${${(z)${version[1]}}[3]}
first=$(echo $version|cut -d '.' -f 1)
second=$(echo $version|cut -d '.' -f 2)
third=$(echo $version|cut -d '.' -f 3)
if (( $first < 2 )) && (( $second < 7 )) && (( $third < 3 ));then

autoload -Uz is-at-least
if ! is-at-least 1.6.3 "$version"; then
opts+=('(-l --lint)'{-l,--lint}'[pipe the compiled JavaScript through JavaScript Lint]'
'(-r --require)'{-r,--require}'[require a library before executing your script]:library')
fi
Expand Down

0 comments on commit 9350e1f

Please sign in to comment.