[AUD-1103] Fix probers (#37)

* [AUD-1103] Make probers create account tolerant to network ordering * Fix node version to 14.18 * Add test output directory * Bump resource class
AudiusProject · Nov 30, 2021 · 1d9e995 · 1d9e995
1 parent 65ce806
commit 1d9e995
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 6 deletions.
diff --git a/packages/probers/.circleci/config.yml b/packages/probers/.circleci/config.yml
@@ -23,7 +23,8 @@ jobs:
   coverage:
     working_directory: ~/
     docker:
-      - image: circleci/node:latest-browsers
+      - image: circleci/node:14.18-browsers
+    resource_class: large
     steps:
       - attach_workspace:
           at: ./
@@ -53,7 +54,7 @@ jobs:
   pings:
     working_directory: ~/probers
     docker:
-      - image: circleci/node:latest-browsers
+      - image: circleci/node:14.18-browsers
     steps:
       - checkout
 

diff --git a/packages/probers/.gitignore b/packages/probers/.gitignore
@@ -1,4 +1,4 @@
 node_modules
 .DS_Store
 **.account-credentials.json
-test_output
+test_output/**.png
diff --git a/packages/probers/README.md b/packages/probers/README.md
@@ -89,5 +89,9 @@ program
 
 Take a screenshot
 ```js
-await page.screenshot({ path: 'test_output/example.png' });
+
+await page.ss('example')
+
+// Under the hood will call (which you may also do)
+// await page.screenshot({ path: 'test_output/example.png' });
 ```
diff --git a/packages/probers/src/flows/create-account.js b/packages/probers/src/flows/create-account.js
@@ -97,10 +97,10 @@ export const createAccount = async (page, baseUrl, uploadPhoto = false) => {
   await page.waitForXPath("//span[contains(text(), 'Start Listening')]", {
     timeout: 5 /* min */ * 60 /* sec */ * 1000 /* ms */
   })
-  await waitForAndClickButton(page, 'startListening')
 
   // We still may be following users and playlists in the background, so wait
-  await waitForNetworkIdle0(page)
+  // for network idle in addition to clicking startListening
+  await waitForNetworkIdle0(page, waitForAndClickButton(page, 'startListening'))
 
   // Export account so it can be re-used in other tests that don't want a fresh state
   const entropy = await getEntropy(page)

diff --git a/packages/probers/src/utils/index.js b/packages/probers/src/utils/index.js
@@ -3,11 +3,18 @@ import getConfig from '../config'
 
 export const newPage = async (width = 1600, height = 960) => {
   let page = await global.__BROWSER__.newPage()
+
   page.setViewport({
     width,
     height
   })
   await page.setDefaultNavigationTimeout(0);
+
+  // Monkeypatch page screenshot method for ease of debugging
+  page.ss = async (identifier) => {
+    await page.screenshot({ path: `test_output/${identifier}.png` })
+  }
+
   return page
 }
 

diff --git a/packages/probers/test_output/README.md b/packages/probers/test_output/README.md
@@ -0,0 +1 @@
+Test output directory