[PAY-1725] Display proper amount in track sold notification (#4039)

Co-authored-by: Saliou Diallo <saliou@audius.co>
AudiusProject · Sep 7, 2023 · 52f0375 · 52f0375
1 parent c56596b
commit 52f0375
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/packages/common/src/services/audius-backend/AudiusBackend.ts b/packages/common/src/services/audius-backend/AudiusBackend.ts
@@ -41,6 +41,7 @@ import {
   PlaylistTrackId,
   ProfilePictureSizes,
   SquareSizes,
+  StringUSDC,
   StringWei,
   Track,
   TrackMetadata,
@@ -2183,7 +2184,7 @@ export const audiusBackend = ({
     } else if (notification.type === 'usdc_purchase_seller') {
       let entityId = 0
       let entityType = Entity.Track
-      let amount = 0
+      let amount = '' as StringUSDC
       const userIds = notification.actions
         .map((action) => {
           const data = action.data

diff --git a/packages/common/src/store/notifications/types.ts b/packages/common/src/store/notifications/types.ts
@@ -7,7 +7,7 @@ import { ID } from 'models/Identifiers'
 import { Status } from 'models/Status'
 import { Track } from 'models/Track'
 import { User } from 'models/User'
-import { StringWei } from 'models/Wallet'
+import { StringUSDC, StringWei } from 'models/Wallet'
 import { Nullable } from 'utils'
 
 export enum NotificationType {
@@ -247,7 +247,7 @@ export type DiscoveryUSDCPurchaseNotificationAction = {
   content_id: string
   seller_user_id: string
   buyer_user_id: string
-  amount: number
+  amount: StringUSDC
 }
 
 export type TrendingRange = 'week' | 'month' | 'year'
@@ -891,7 +891,7 @@ export type USDCPurchaseSellerNotification = BaseNotification & {
   entityId: ID
   userIds: ID[]
   entityType: string
-  amount: number
+  amount: StringUSDC
 }
 
 export type USDCPurchaseBuyerNotification = BaseNotification & {

diff --git a/.../mobile/src/screens/notifications-screen/Notifications/USDCPurchaseSellerNotification.tsx b/.../mobile/src/screens/notifications-screen/Notifications/USDCPurchaseSellerNotification.tsx
@@ -5,7 +5,10 @@ import type {
   TrackEntity,
   USDCPurchaseSellerNotification as USDCPurchaseSellerNotificationType
 } from '@audius/common'
-import { formatPrice, notificationsSelectors } from '@audius/common'
+import {
+  formatUSDCWeiToUSDString,
+  notificationsSelectors
+} from '@audius/common'
 import { useSelector } from 'react-redux'
 
 import IconCart from 'app/assets/images/iconCart.svg'
@@ -63,7 +66,7 @@ export const USDCPurchaseSellerNotification = (
       <NotificationText>
         {messages.congrats} <UserNameLink user={buyerUser} />{' '}
         {messages.justBoughtYourTrack} <EntityLink entity={track} /> for $
-        {formatPrice(amount)}
+        {formatUSDCWeiToUSDString(amount)}
         {messages.exclamation}
       </NotificationText>
     </NotificationTile>

diff --git a/packages/web/src/components/notification/Notification/USDCPurchaseSellerNotification.tsx b/packages/web/src/components/notification/Notification/USDCPurchaseSellerNotification.tsx
@@ -2,7 +2,7 @@ import { useCallback } from 'react'
 
 import {
   Entity,
-  formatPrice,
+  formatUSDCWeiToUSDString,
   notificationsSelectors,
   Nullable,
   TrackEntity,
@@ -65,7 +65,7 @@ export const USDCPurchaseSellerNotification = (
         <UserNameLink user={buyerUser} notification={notification} />{' '}
         {messages.justBoughtYourTrack}{' '}
         <EntityLink entity={track} entityType={Entity.Track} /> for $
-        {formatPrice(amount)}
+        {formatUSDCWeiToUSDString(amount)}
         {messages.exclamation}
       </NotificationBody>
     </NotificationTile>