Dual writes when setting artist pick (#2128)

* Add write path using updateCreator

* Add artist_pick_track_id to userMetadataSchema used in AudiusBackend

* Add artist_pick_track_id to APIUser type

* Set artist_pick_track_id to identity service value when populating cache

* Pin keyv version

* Move to devDependencies

* Wait for user to be fetched when deleting track

* waitForValue, typecheck errors

* Typo

package.json

@@ -30,6 +30,7 @@
     "stems": "cd packages/stems && npm run start"
   },
   "devDependencies": {
+    "@types/keyv": "4.2.0",
     "@typescript-eslint/eslint-plugin": "5.40.0",
     "@typescript-eslint/parser": "5.40.0",
     "concurrently": "7.4.0",
@@ -55,7 +56,6 @@
     "wait-on": "6.0.1"
   },
   "dependencies": {
-    "@escape.tech/mookme": "2.2.0",
-    "@types/keyv": "^4.2.0"
+    "@escape.tech/mookme": "2.2.0"
   }
 }

packages/common/src/models/User.ts

@@ -10,6 +10,7 @@ import { Timestamped } from './Timestamped'
 
 export type UserMetadata = {
   album_count: number
+  artist_pick_track_id: number | null,
   bio: string | null
   cover_photo: Nullable<CID>
   creator_node_endpoint: Nullable<string>

packages/common/src/schemas/index.ts

@@ -113,7 +113,8 @@ const userMetadataSchema = {
   collectibles: null,
   playlist_library: null,
   events: null,
-  is_deactivated: false
+  is_deactivated: false,
+  artist_pick_track_id: null
 }
 
 export const newUserMetadata = (fields?: any, validate = false) => {

packages/common/src/services/audius-api-client/types.ts

@@ -22,6 +22,7 @@ export type OpaqueID = string
 
 export type APIUser = {
   album_count: number
+  artist_pick_track_id: Nullable<number>
   blocknumber: number
   balance: string
   associated_wallets_balance: string

packages/common/src/services/audius-backend/AudiusBackend.ts

@@ -2158,11 +2158,23 @@ export const audiusBackend = ({
 
   /**
    * Sets the artist pick for a user
+   * @param {User} userMetadata
+   * @param {number} userId
    * @param {number?} trackId if null, unsets the artist pick
    */
-  async function setArtistPick(trackId: Nullable<ID> = null) {
+  async function setArtistPick(
+    userMetadata: User,
+    userId: ID,
+    trackId: Nullable<ID> = null
+  ) {
     await waitForLibsInit()
     try {
+      // Dual write to the artist_pick_track_id field in the
+      // users table in the discovery DB. Part of the migration
+      // of the artist pick feature from the identity service
+      // to the entity manager in discovery.
+      updateCreator(userMetadata, userId)
+
       const { data, signature } = await signData()
       return await fetch(`${identityServiceUrl}/artist_pick`, {
         method: 'POST',

packages/web/src/common/store/cache/tracks/sagas.js

@@ -338,15 +338,19 @@ function* deleteTrackAsync(action) {
     handle
   )
   if (socials.pinnedTrackId === action.trackId) {
-    yield call(audiusBackendInstance.setArtistPick)
     yield put(
       cacheActions.update(Kind.USERS, [
         {
           id: userId,
-          metadata: { _artist_pick: null }
+          metadata: {
+            artist_pick_track_id: null,
+            _artist_pick: null
+          }
         }
       ])
     )
+    const user = yield call(waitForValue, getUser, { id: userId })
+    yield call(audiusBackendInstance.setArtistPick, user, userId)
   }
 
   const track = yield select(getTrack, { id: action.trackId })

packages/web/src/common/store/cache/users/sagas.js

@@ -407,7 +407,8 @@ export function* fetchUserSocials({ handle }) {
           tiktok_handle: socials.tikTokHandle || null,
           website: socials.website || null,
           donation: socials.donation || null,
-          _artist_pick: socials.pinnedTrackId || null
+          _artist_pick: socials.pinnedTrackId || null,
+          artist_pick_track_id: socials.pinnedTrackId || null
         }
       }
     ])

packages/web/src/common/store/social/tracks/sagas.ts

@@ -540,15 +540,25 @@ export function* watchSetArtistPick() {
     function* (action: ReturnType<typeof socialActions.setArtistPick>) {
       yield* waitForAccount()
       const userId = yield* select(getUserId)
+      if (!userId) return
       yield* put(
         cacheActions.update(Kind.USERS, [
           {
             id: userId,
-            metadata: { _artist_pick: action.trackId }
+            metadata: {
+              artist_pick_track_id: action.trackId,
+              _artist_pick: action.trackId
+            }
           }
         ])
       )
-      yield* call(audiusBackendInstance.setArtistPick, action.trackId)
+      const user = yield* call(waitForValue, getUser, { id: userId })
+      yield* call(
+        audiusBackendInstance.setArtistPick,
+        user,
+        userId,
+        action.trackId
+      )
 
       const event = make(Name.ARTIST_PICK_SELECT_TRACK, { id: action.trackId })
       yield* put(event)
@@ -561,15 +571,20 @@ export function* watchUnsetArtistPick() {
   yield* takeEvery(socialActions.UNSET_ARTIST_PICK, function* (action) {
     yield* waitForAccount()
     const userId = yield* select(getUserId)
+    if (!userId) return
     yield* put(
       cacheActions.update(Kind.USERS, [
         {
           id: userId,
-          metadata: { _artist_pick: null }
+          metadata: {
+            artist_pick_track_id: null,
+            _artist_pick: null
+          }
         }
       ])
     )
-    yield* call(audiusBackendInstance.setArtistPick)
+    const user = yield* call(waitForValue, getUser, { id: userId })
+    yield* call(audiusBackendInstance.setArtistPick, user, userId)
 
     const event = make(Name.ARTIST_PICK_SELECT_TRACK, { id: 'none' })
     yield* put(event)