[C-3001, C-3003] Fix new upload flow error formatting (#3953)

AudiusProject · Aug 28, 2023 · f8dcd92 · f8dcd92
1 parent 4727ef4
commit f8dcd92
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 17 deletions.
diff --git a/packages/web/src/pages/upload-page/fields/AccessAndSaleField.tsx b/packages/web/src/pages/upload-page/fields/AccessAndSaleField.tsx
@@ -108,13 +108,13 @@ const messages = {
   },
   errors: {
     price: {
-      tooLow: 'Price must be at least $0.99',
-      tooHigh: 'Price must be less than $9.99'
+      tooLow: 'Price must be at least $0.99.',
+      tooHigh: 'Price must be less than $9.99.'
     },
     preview: {
-      tooEarly: 'Preview must start during the track',
+      tooEarly: 'Preview must start during the track.',
       tooLate:
-        'Preview must start at lest 15 seconds before the end of the track'
+        'Preview must start at lest 15 seconds before the end of the track.'
     }
   }
 }

diff --git a/packages/web/src/pages/upload-page/fields/AttributionField.tsx b/packages/web/src/pages/upload-page/fields/AttributionField.tsx
@@ -45,17 +45,17 @@ const messages = {
     description:
       'If your AI generated track was trained on an existing Audius artist, you can give them credit here. Only users who have opted-in will appear in this list.',
     placeholder: 'Search for Users',
-    requiredError: 'Valid user must be selected'
+    requiredError: 'Valid user must be selected.'
   },
   isrc: {
     header: 'ISRC',
     placeholder: 'CC-XXX-YY-NNNNN',
-    validError: 'Must be valid ISRC format'
+    validError: 'Must be valid ISRC format.'
   },
   iswc: {
     header: 'ISWC',
     placeholder: 'T-345246800-1',
-    validError: 'Must be valid ISWC format'
+    validError: 'Must be valid ISWC format.'
   },
   licenseType: 'License Type',
   allowAttribution: {

diff --git a/packages/web/src/pages/upload-page/fields/MultiTrackSidebar.module.css b/packages/web/src/pages/upload-page/fields/MultiTrackSidebar.module.css
@@ -27,6 +27,10 @@
   width: 12px;
 }
 
+.iconError path {
+  fill: var(--accent-red);
+}
+
 /* Track */
 .tracks {
   margin: 0 calc(-1 * var(--unit-4));

diff --git a/packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx b/packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx
@@ -55,7 +55,6 @@ export const MultiTrackSidebar = () => {
                 className={styles.iconError}
                 icon={IconError}
                 size='xSmall'
-                fill='accentRed'
               />
               <Text size='xSmall' color='accentRed'>
                 {messages.fixErrors}

diff --git a/packages/web/src/pages/upload-page/forms/EditTrackForm.tsx b/packages/web/src/pages/upload-page/forms/EditTrackForm.tsx
@@ -31,9 +31,9 @@ import { TrackMetadataSchema } from '../validation'
 import styles from './EditTrackForm.module.css'
 
 const messages = {
-  titleError: 'Your track must have a name',
-  artworkError: 'Artwork is required',
-  genreError: 'Genre is required',
+  titleError: 'Your track must have a name.',
+  artworkError: 'Artwork is required.',
+  genreError: 'Genre is required.',
   multiTrackCount: (index: number, total: number) =>
     `TRACK ${index} of ${total}`,
   prev: 'Prev',

diff --git a/packages/web/src/pages/upload-page/validation.ts b/packages/web/src/pages/upload-page/validation.ts
@@ -9,17 +9,17 @@ import {
 import { z } from 'zod'
 
 const messages = {
-  invalidReleaseDateError: 'Release date should not be in the future',
-  artworkRequiredError: 'Artwork is required',
-  genreRequiredError: 'Genre is required',
+  invalidReleaseDateError: 'Release date should not be in the future.',
+  artworkRequiredError: 'Artwork is required.',
+  genreRequiredError: 'Genre is required.',
   track: {
-    titleRequiredError: 'Your track must have a name'
+    titleRequiredError: 'Your track must have a name.'
   },
   playlist: {
-    nameRequiredError: 'Your playlist must have a name'
+    nameRequiredError: 'Your playlist must have a name.'
   },
   album: {
-    nameRequiredError: 'Your album must have a name'
+    nameRequiredError: 'Your album must have a name.'
   }
 }